docs: fix Pages Router fonts documentation showing App Router examples#88326
Merged
timneutkens merged 2 commits intocanaryfrom Jan 15, 2026
Merged
docs: fix Pages Router fonts documentation showing App Router examples#88326timneutkens merged 2 commits intocanaryfrom
timneutkens merged 2 commits intocanaryfrom
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
icyJoseph
reviewed
Jan 12, 2026
icyJoseph
reviewed
Jan 12, 2026
The Pages Router fonts documentation was incorrectly showing App Router examples (app/layout.tsx) which don't exist in Pages Router. Added proper <AppOnly> and <PagesOnly> sections to show router-specific examples: - Pages Router: pages/_app.tsx and pages/_document.tsx examples - App Router: app/layout.tsx examples (existing) Fixes #88291
8fa1c26 to
3e7b41f
Compare
samselikoff
approved these changes
Jan 14, 2026
icyJoseph
pushed a commit
that referenced
this pull request
Jan 22, 2026
#88326) ## Summary Fixes #88291 The Pages Router fonts documentation was incorrectly showing App Router examples (`app/layout.tsx`) which don't exist in Pages Router. This confused users trying to use fonts with the Pages Router. ## Changes Updated `docs/01-app/01-getting-started/13-fonts.mdx` to include proper `<AppOnly>` and `<PagesOnly>` sections: **For Pages Router users:** - Added examples using `pages/_app.tsx` (Custom App) to wrap components with font className - Added examples using `pages/_document.tsx` (Custom Document) to apply fonts to the `<html>` element **For App Router users:** - Wrapped existing `app/layout.tsx` examples in `<AppOnly>` sections This follows the same pattern used in other shared documentation like `docs/01-app/01-getting-started/11-css.mdx` which properly separates App Router and Pages Router content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #88291
The Pages Router fonts documentation was incorrectly showing App Router examples (
app/layout.tsx) which don't exist in Pages Router. This confused users trying to use fonts with the Pages Router.Changes
Updated
docs/01-app/01-getting-started/13-fonts.mdxto include proper<AppOnly>and<PagesOnly>sections:For Pages Router users:
pages/_app.tsx(Custom App) to wrap components with font classNamepages/_document.tsx(Custom Document) to apply fonts to the<html>elementFor App Router users:
app/layout.tsxexamples in<AppOnly>sectionsThis follows the same pattern used in other shared documentation like
docs/01-app/01-getting-started/11-css.mdxwhich properly separates App Router and Pages Router content.