-
Notifications
You must be signed in to change notification settings - Fork 30.3k
Turbopack: improve error message for incompatible swc plugins #86346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cd34493 to
224f11c
Compare
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
224f11c to
8d6457d
Compare
Tests Passed |
8d6457d to
e0a3c51
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **430 kB** → **430 kB** ✅ -4 B82 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
|
e0a3c51 to
768515a
Compare
bgw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer! Thank you!
| fn description(&self) -> Vc<OptionStyledString> { | ||
| Vc::cell(Some( | ||
| StyledString::Stack(vec![ | ||
| StyledString::Text(rcstr!( | ||
| "An unexpected error occurred when executing an SWC EcmaScript transform \ | ||
| plugin." | ||
| )), | ||
| StyledString::Text(rcstr!( | ||
| "This might be due to a version mismatch between the plugin and Next.js." | ||
| )), | ||
| StyledString::Text(Default::default()), | ||
| self.description.clone(), | ||
| ]) | ||
| .resolved_cell(), | ||
| )) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could link to https://plugins.swc.rs/
I don't know this this should be part of description or documentation_link though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turbopack/crates/turbopack-ecmascript-plugins/src/transform/swc_ecma_transform_plugins.rs
Outdated
Show resolved
Hide resolved
768515a to
70b8754
Compare


Before:
After: