Skip to content

Limit the number of concurrently open file watchers on macos#73741

Merged
sokra merged 1 commit intocanaryfrom
sokra/fix-watch-close-perf
Dec 10, 2024
Merged

Limit the number of concurrently open file watchers on macos#73741
sokra merged 1 commit intocanaryfrom
sokra/fix-watch-close-perf

Conversation

@sokra
Copy link
Member

@sokra sokra commented Dec 10, 2024 •
edited by padmaia
Loading

What?

This adds a workaround for a Node.js bug on MacOS which causes closing file watchers to be really slow:
nodejs/node#29949

It was fixed before here: #51826
But accidentically removed here: c5a8e09#diff-0ff576bd02e76f96680accff48ecbe4126a7f6bc4eafa547b6d44dee49bab770L88

Closes PACK-3636

@sokra
Limit the number of concurrently open file watchers on macos
456589a 
There is a node.js bug on MacOS which causes closing file watchers to be really slow.
nodejs/node#29949
@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. type: next labels Dec 10, 2024
@sokra Graphite App
Copy link
Member Author

sokra commented Dec 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra marked this pull request as ready for review December 10, 2024 14:32
@ijjk
Copy link
Member

ijjk commented Dec 10, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/fix-watch-close-perf Change
buildDuration 18.1s 15.5s N/A
buildDurationCached 14.7s 12.6s N/A
nodeModulesSize 409 MB 409 MB ⚠️ +1.66 kB
nextStartRea..uration (ms) 469ms 453ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/fix-watch-close-perf Change
1187-HASH.js gzip 50.2 kB 50.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 33.8 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/fix-watch-close-perf Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sokra/fix-watch-close-perf Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/fix-watch-close-perf Change
_buildManifest.js gzip 747 B 745 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/fix-watch-close-perf Change
index.html gzip 524 B 523 B N/A
link.html gzip 538 B 538 B ✓
withRouter.html gzip 520 B 520 B ✓
Overall change 1.06 kB 1.06 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/fix-watch-close-perf Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sokra/fix-watch-close-perf Change
middleware-b..fest.js gzip 671 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31 kB 31 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js sokra/fix-watch-close-perf Change
523-experime...dev.js gzip 322 B 322 B ✓
523.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 322 kB 322 kB ✓
app-page-exp..prod.js gzip 127 kB 127 kB ✓
app-page-tur..prod.js gzip 140 kB 140 kB ✓
app-page-tur..prod.js gzip 135 kB 135 kB ✓
app-page.run...dev.js gzip 312 kB 312 kB ✓
app-page.run..prod.js gzip 122 kB 122 kB ✓
app-route-ex...dev.js gzip 37.1 kB 37.1 kB ✓
app-route-ex..prod.js gzip 25.1 kB 25.1 kB ✓
app-route-tu..prod.js gzip 25.1 kB 25.1 kB ✓
app-route-tu..prod.js gzip 24.9 kB 24.9 kB ✓
app-route.ru...dev.js gzip 38.7 kB 38.7 kB ✓
app-route.ru..prod.js gzip 24.9 kB 24.9 kB ✓
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB ✓
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB ✓
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB ✓
pages-turbo...prod.js gzip 21.3 kB 21.3 kB ✓
pages.runtim...dev.js gzip 27 kB 27 kB ✓
pages.runtim..prod.js gzip 21.3 kB 21.3 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.35 MB 2.35 MB ✓
build cache
vercel/next.js canary vercel/next.js sokra/fix-watch-close-perf Change
0.pack gzip 2.04 MB 2.03 MB N/A
index.pack gzip 72.9 kB 72.3 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 456589a

@ijjk
Copy link
Member

ijjk commented Dec 10, 2024 •
edited
Loading

Tests Passed

@sokra sokra merged commit 416c137 into canary Dec 10, 2024
@sokra Graphite App
Copy link
Member Author

sokra commented Dec 10, 2024

Merge activity

  • Dec 10, 10:17 AM EST: A user merged this pull request with Graphite.

@sokra sokra deleted the sokra/fix-watch-close-perf branch December 10, 2024 15:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mischnic mischnic mischnic approved these changes

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. locked type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sokra @ijjk @mischnic