Correct parseNodeArgs and formatNodeOptions processing of NODE_OPTIONS#71759
Open
martinjlowm wants to merge 3 commits intovercel:canaryfrom
Open
Correct parseNodeArgs and formatNodeOptions processing of NODE_OPTIONS#71759martinjlowm wants to merge 3 commits intovercel:canaryfrom
martinjlowm wants to merge 3 commits intovercel:canaryfrom
Conversation
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
runderworld
added a commit
to runderworld/next.js
that referenced
this pull request
Jul 24, 2025
- custom-patches/next+canary.patch: dist-only diff for applying PR vercel#71759 to Next.js canary - custom-scripts/setup-patch-package.sh: automates installation & wiring of patch-package on npm install
runderworld
added a commit
to runderworld/next.js
that referenced
this pull request
Jul 24, 2025
- custom-patches/next+canary.patch: dist-only diff for applying PR vercel#71759 to Next.js canary - custom-scripts/setup-patch-package.sh: automates installation & wiring of patch-package on npm install
runderworld
added a commit
to runderworld/next.js
that referenced
this pull request
Jul 24, 2025
- custom-patches/next+canary.patch: dist-only diff for applying PR vercel#71759 to Next.js canary - custom-scripts/setup-patch-package.sh: automates installation & wiring of patch-package on npm install
runderworld
added a commit
to runderworld/next.js
that referenced
this pull request
Jul 24, 2025
- custom-patches/next+canary.patch: dist-only diff for applying PR vercel#71759 to Next.js canary - custom-scripts/setup-patch-package.sh: automates installation & wiring of patch-package on npm install
runderworld
added a commit
to runderworld/next.js
that referenced
this pull request
Jul 24, 2025
- custom-patches/next+canary.patch: dist-only diff for applying PR vercel#71759 to Next.js canary - custom-scripts/setup-patch-package.sh: automates installation & wiring of patch-package on npm install
runderworld
added a commit
to runderworld/next.js
that referenced
this pull request
Aug 30, 2025
- custom-patches/next+canary.patch: dist-only diff for applying PR vercel#71759 to Next.js canary - custom-scripts/setup-patch-package.sh: automates installation & wiring of patch-package on npm install
|
@martinjlowm I updated your PR in my fork to be compatible with |
Comment on lines
+188
to
+208
| .map(([key, values]) => { | ||
| return values | ||
| .map((value) => { | ||
| if (value === true) { | ||
| return key | ||
| } | ||
|
|
||
| if (value) { | ||
| // Values with spaces need to be quoted. We use JSON.stringify to | ||
| // also escape any nested quotes. | ||
| const encodedValue = | ||
| value.includes(' ') && !value.startsWith('"') | ||
| ? JSON.stringify(value) | ||
| : value | ||
|
|
||
| return `${key}${key.startsWith('--') ? '=' : ' '}${encodedValue}` | ||
| } | ||
|
|
||
| return null | ||
| }) | ||
| .join(' ') |
Contributor
There was a problem hiding this comment.
Logic error in nested array processing: The inner map operation on line 190 can return null values (line 206), but these nulls are joined with spaces (line 208) before being filtered out (line 211). This will create strings with extra spaces like 'option1 option3' when null values are joined. The filter should be applied to each inner array before joining, not after the outer join.
Suggested change
| .map(([key, values]) => { | |
| return values | |
| .map((value) => { | |
| if (value === true) { | |
| return key | |
| } | |
| if (value) { | |
| // Values with spaces need to be quoted. We use JSON.stringify to | |
| // also escape any nested quotes. | |
| const encodedValue = | |
| value.includes(' ') && !value.startsWith('"') | |
| ? JSON.stringify(value) | |
| : value | |
| return `${key}${key.startsWith('--') ? '=' : ' '}${encodedValue}` | |
| } | |
| return null | |
| }) | |
| .join(' ') | |
| .map(([key, values]) => { | |
| return values | |
| .map((value) => { | |
| if (value === true) { | |
| return key | |
| } | |
| if (value) { | |
| // Values with spaces need to be quoted. We use JSON.stringify to | |
| // also escape any nested quotes. | |
| const encodedValue = | |
| value.includes(' ') && !value.startsWith('"') | |
| ? JSON.stringify(value) | |
| : value | |
| return `${key}${key.startsWith('--') ? '=' : ' '}${encodedValue}` | |
| } | |
| return null | |
| }) | |
| .filter(Boolean) | |
| .join(' ') |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
runderworld
added a commit
to runderworld/next.js
that referenced
this pull request
Dec 5, 2025
- custom-patches/next+canary.patch: dist-only diff for applying PR vercel#71759 to Next.js canary - custom-scripts/setup-patch-package.sh: automates installation & wiring of patch-package on npm install
runderworld
added a commit
to runderworld/next.js
that referenced
this pull request
Feb 13, 2026
…PTIONS Fixes vercel#77550 — Port of PR vercel#71759 to v16.x (canary). The core issue: parseNodeArgs used node:util parseArgs which strips dash prefixes and deduplicates keys. When NODE_OPTIONS contains repeated short options like '-r file1.js -r file2.js', the old code lost values and formatNodeOptions forced '--' prefix on everything (turning '-r' into '--r=', which is invalid in NODE_OPTIONS). Changes: - parseNodeArgs now uses token.rawName to preserve '-' vs '--' prefixes and stores values as arrays to support repeated options - Introduced NodeOptions class wrapping the parsed result with get/set/ delete/has/clone/raw helpers for clean caller interaction - formatNodeOptions updated to handle array values and use the correct separator ('=' for long options, ' ' for short options) - Updated callers in next-dev.ts and worker.ts to use NodeOptions methods - Added tests for repeated -r/--require options (short and long forms), short option formatting, repeated option formatting, and boolean options - Applied Graphite bot suggestion: filter(Boolean) before join in inner map to avoid extra spaces from null values
runderworld
added a commit
to runderworld/next.js
that referenced
this pull request
Feb 13, 2026
…PTIONS Fixes vercel#77550 — Port of PR vercel#71759 to v16.x (canary). The core issue: parseNodeArgs used node:util parseArgs which strips dash prefixes and deduplicates keys. When NODE_OPTIONS contains repeated short options like '-r file1.js -r file2.js', the old code lost values and formatNodeOptions forced '--' prefix on everything (turning '-r' into '--r=', which is invalid in NODE_OPTIONS). Changes: - parseNodeArgs now uses token.rawName to preserve '-' vs '--' prefixes and stores values as arrays to support repeated options - Introduced NodeOptions class wrapping the parsed result with get/set/ delete/has/clone/raw helpers for clean caller interaction - formatNodeOptions updated to handle array values and use the correct separator ('=' for long options, ' ' for short options) - Updated callers in next-dev.ts and worker.ts to use NodeOptions methods - Added tests for repeated -r/--require options (short and long forms), short option formatting, repeated option formatting, and boolean options - Applied Graphite bot suggestion: filter(Boolean) before join in inner map to avoid extra spaces from null values
runderworld
added a commit
to runderworld/next.js
that referenced
this pull request
Feb 13, 2026
…PTIONS Fixes vercel#77550 — Port of PR vercel#71759 to v16.x (canary). The core issue: parseNodeArgs used node:util parseArgs which strips dash prefixes and deduplicates keys. When NODE_OPTIONS contains repeated short options like '-r file1.js -r file2.js', the old code lost values and formatNodeOptions forced '--' prefix on everything (turning '-r' into '--r=', which is invalid in NODE_OPTIONS). Changes: - parseNodeArgs now uses token.rawName to preserve '-' vs '--' prefixes and stores values as arrays to support repeated options - Introduced NodeOptions class wrapping the parsed result with get/set/ delete/has/clone/raw helpers for clean caller interaction - formatNodeOptions updated to handle array values and use the correct separator ('=' for long options, ' ' for short options) - Updated callers in next-dev.ts and worker.ts to use NodeOptions methods - Added tests for repeated -r/--require options (short and long forms), short option formatting, repeated option formatting, and boolean options - Applied Graphite bot suggestion: filter(Boolean) before join in inner map to avoid extra spaces from null values
runderworld
added a commit
to runderworld/next.js
that referenced
this pull request
Feb 21, 2026
…PTIONS Fixes vercel#77550 — Port of PR vercel#71759 to v16.x (canary). The core issue: parseNodeArgs used node:util parseArgs which strips dash prefixes and deduplicates keys. When NODE_OPTIONS contains repeated short options like '-r file1.js -r file2.js', the old code lost values and formatNodeOptions forced '--' prefix on everything (turning '-r' into '--r=', which is invalid in NODE_OPTIONS). Changes: - parseNodeArgs now uses token.rawName to preserve '-' vs '--' prefixes and stores values as arrays to support repeated options - Introduced NodeOptions class wrapping the parsed result with get/set/ delete/has/clone/raw helpers for clean caller interaction - formatNodeOptions updated to handle array values and use the correct separator ('=' for long options, ' ' for short options) - Updated callers in next-dev.ts and worker.ts to use NodeOptions methods - Added tests for repeated -r/--require options (short and long forms), short option formatting, repeated option formatting, and boolean options - Applied Graphite bot suggestion: filter(Boolean) before join in inner map to avoid extra spaces from null values
runderworld
added a commit
to runderworld/next.js
that referenced
this pull request
Feb 21, 2026
…PTIONS Fixes vercel#77550 — Port of PR vercel#71759 to v16.x (canary). The core issue: parseNodeArgs used node:util parseArgs which strips dash prefixes and deduplicates keys. When NODE_OPTIONS contains repeated short options like '-r file1.js -r file2.js', the old code lost values and formatNodeOptions forced '--' prefix on everything (turning '-r' into '--r=', which is invalid in NODE_OPTIONS). Changes: - parseNodeArgs now uses token.rawName to preserve '-' vs '--' prefixes and stores values as arrays to support repeated options - Introduced NodeOptions class wrapping the parsed result with get/set/ delete/has/clone/raw helpers for clean caller interaction - formatNodeOptions updated to handle array values and use the correct separator ('=' for long options, ' ' for short options) - Updated callers in next-dev.ts and worker.ts to use NodeOptions methods - Added tests for repeated -r/--require options (short and long forms), short option formatting, repeated option formatting, and boolean options - Applied Graphite bot suggestion: filter(Boolean) before join in inner map to avoid extra spaces from null values
runderworld
added a commit
to runderworld/next.js
that referenced
this pull request
Feb 21, 2026
…PTIONS Fixes vercel#77550 — Port of PR vercel#71759 to v16.x (canary). The core issue: parseNodeArgs used node:util parseArgs which strips dash prefixes and deduplicates keys. When NODE_OPTIONS contains repeated short options like '-r file1.js -r file2.js', the old code lost values and formatNodeOptions forced '--' prefix on everything (turning '-r' into '--r=', which is invalid in NODE_OPTIONS). Changes: - parseNodeArgs now uses token.rawName to preserve '-' vs '--' prefixes and stores values as arrays to support repeated options - Introduced NodeOptions class wrapping the parsed result with get/set/ delete/has/clone/raw helpers for clean caller interaction - formatNodeOptions updated to handle array values and use the correct separator ('=' for long options, ' ' for short options) - Updated callers in next-dev.ts and worker.ts to use NodeOptions methods - Added tests for repeated -r/--require options (short and long forms), short option formatting, repeated option formatting, and boolean options - Applied Graphite bot suggestion: filter(Boolean) before join in inner map to avoid extra spaces from null values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't fix any reported issue - a reproducible link was not applicable for this case hence why I didn't create an issue (sounded like a hard requirement).
What?
--r=is an invalid value if passed to NODE_OPTIONS which could've been the outcome previously from-r file.js, because all options were forcefully prefixed with--that could lead to such invalid options.Why?
parseNodeArgsandformatNodeOptionscurrently does not account for short options that also may have values and not simply be a boolean.How?
The implementations now uses the token "
rawName" to include single or double dashes and accounts for there being repeated options by storing values in an array.