Skip to content

Conversation

@ztanner
Copy link
Member

@ztanner ztanner commented Sep 5, 2024

This component is used in Pages which doesn't support async components. It silently worked because React 19 was used in pages but breaks in React 18.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Sep 5, 2024
@ijjk
Copy link
Member

ijjk commented Sep 5, 2024

Failing test suites

Commit: 45a7c89

TURBOPACK=1 pnpm test-dev test/development/acceptance/ReactRefreshLogBox-builtins.test.ts (turbopack)

  • ReactRefreshLogBox turbo > Module not found (missing global CSS)
Expand output

● ReactRefreshLogBox turbo › Module not found (missing global CSS)

Expected no Redbox but found one
header: Build Error
Next.js (15.0.0-canary.142) (turbo)

Failed to compile
description: Failed to compile
source: ./pages/_app.js:1:1
Module not found: Can't resolve './non-existent.css'
> 1 | export default function App({ Component, pageProps }) {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  2 |   return <Component {...pageProps} />
  3 | }

https://nextjs.org/docs/messages/module-not-found

  239 |       `
  240 |     )
> 241 |     await session.assertNoRedbox()
      |     ^
  242 |     expect(
  243 |       await session.evaluate(() => document.documentElement.innerHTML)
  244 |     ).toContain('index page')

  at Object.<anonymous> (development/acceptance/ReactRefreshLogBox-builtins.test.ts:241:5)

Read more about building and testing Next.js in contributing.md.

TURBOPACK=1 pnpm test-dev test/e2e/getserversideprops/test/index.test.ts (turbopack)

  • getServerSideProps > should dedupe server data requests
Expand output

● getServerSideProps › should dedupe server data requests

elementHandle.click: Element is not attached to the DOM
Call log:
  - attempting click action
  -   waiting for element to be visible, enabled and stable
  -   element is visible, enabled and stable
  -   scrolling into view if needed
  -   done scrolling
  -   <nextjs-portal></nextjs-portal> intercepts pointer events
  - retrying click action, attempt #1
  -   waiting for element to be visible, enabled and stable
  -   element is visible, enabled and stable
  -   scrolling into view if needed
  -   done scrolling
  -   <nextjs-portal></nextjs-portal> intercepts pointer events
  - retrying click action, attempt #2
  -   waiting 20ms
  -   waiting for element to be visible, enabled and stable
  -   element is visible, enabled and stable
  -   scrolling into view if needed
  -   done scrolling
  -   <nextjs-portal></nextjs-portal> intercepts pointer events
  - retrying click action, attempt #3
  -   waiting 100ms
  -   waiting for element to be visible, enabled and stable
  -   element is visible, enabled and stable
  -   scrolling into view if needed
  -   done scrolling
  -   <nextjs-portal></nextjs-portal> intercepts pointer events
  - retrying click action, attempt #4
  -   waiting 100ms
  -   waiting for element to be visible, enabled and stable
  -   element is visible, enabled and stable
  -   scrolling into view if needed
  -   done scrolling
  -   <nextjs-portal></nextjs-portal> intercepts pointer events
  - retrying click action, attempt #5
  -   waiting 500ms
  -   waiting for element to be visible, enabled and stable

  394 |   click() {
  395 |     return this.chain((el: ElementHandleExt) => {
> 396 |       return el.click().then(() => el)
      |                 ^
  397 |     })
  398 |   }
  399 |

  at click (lib/browsers/playwright.ts:396:17)
  at Object.<anonymous> (e2e/getserversideprops/test/index.test.ts:680:5)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/navigation/navigation.test.ts

  • app dir - navigation > browser back to a revalidated page > should load the page
Expand output

● app dir - navigation › browser back to a revalidated page › should load the page

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#submit-button')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)

Read more about building and testing Next.js in contributing.md.

Base automatically changed from 09-05-update_pages-dir_test_for_react_18_assertions to 09-05-re-add_hydration_support_to_react_18_errors September 5, 2024 22:38
An error occurred while trying to automatically change base from 09-05-update_pages-dir_test_for_react_18_assertions to 09-05-re-add_hydration_support_to_react_18_errors September 5, 2024 22:38
Base automatically changed from 09-05-re-add_hydration_support_to_react_18_errors to sebbie/08-30-react-sync_cleanup_inaccurate_peer_dependencies September 5, 2024 22:38
An error occurred while trying to automatically change base from 09-05-re-add_hydration_support_to_react_18_errors to sebbie/08-30-react-sync_cleanup_inaccurate_peer_dependencies September 5, 2024 22:38
…ncies' into 09-05-fix_erroneous_async_component_in_integration_test
@ztanner ztanner marked this pull request as ready for review September 5, 2024 22:39
@ztanner ztanner merged commit 2dde773 into sebbie/08-30-react-sync_cleanup_inaccurate_peer_dependencies Sep 5, 2024
@ztanner ztanner deleted the 09-05-fix_erroneous_async_component_in_integration_test branch September 5, 2024 22:39
ztanner added a commit that referenced this pull request Sep 6, 2024
This component is used in Pages which doesn't support async components.
It silently worked because React 19 was used in pages but breaks in
React 18.
ztanner added a commit that referenced this pull request Sep 9, 2024
This component is used in Pages which doesn't support async components.
It silently worked because React 19 was used in pages but breaks in
React 18.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants