Skip to content

fix: add node-web-audio-api to server-external-packages.json#60243

Merged
styfle merged 1 commit intocanaryfrom
NEXT-1974
Jan 4, 2024
Merged

fix: add node-web-audio-api to server-external-packages.json#60243
styfle merged 1 commit intocanaryfrom
NEXT-1974

Conversation

@styfle
Copy link
Member

@styfle styfle commented Jan 4, 2024 •
edited
Loading

The package node-web-audio-api contains native .node files that cannot be bundled (similar to #57640)

Closes NEXT-1974

@styfle
fix: add node-web-audio-api to server-external-packages.json
7482cdd 
This package contains native `.node` files that cannot be bundled

Fixes NEXT-1974
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 4, 2024
@styfle styfle enabled auto-merge (squash) January 4, 2024 22:05
@ijjk
Copy link
Member

ijjk commented Jan 4, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js NEXT-1974 Change
buildDuration 12.8s 12.9s ⚠️ +154ms
buildDurationCached 7.1s 6.2s N/A
nodeModulesSize 200 MB 200 MB N/A
nextStartRea..uration (ms) 428ms 428ms ✓
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js NEXT-1974 Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB ✓
433-HASH.js gzip 28.5 kB 28.6 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 31.7 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.5 kB 98.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js NEXT-1974 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js NEXT-1974 Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.28 kB 4.28 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB ✓
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.4 kB 3.4 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js NEXT-1974 Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js NEXT-1974 Change
index.html gzip 526 B 526 B ✓
link.html gzip 539 B 539 B ✓
withRouter.html gzip 523 B 521 B N/A
Overall change 1.06 kB 1.06 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js NEXT-1974 Change
edge-ssr.js gzip 93.8 kB 93.8 kB N/A
page.js gzip 147 kB 147 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js NEXT-1974 Change
middleware-b..fest.js gzip 626 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 37.4 kB 37.4 kB ✓
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 39.5 kB 39.5 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js NEXT-1974 Change
app-page-exp...dev.js gzip 169 kB 169 kB ✓
app-page-exp..prod.js gzip 94.2 kB 94.2 kB ✓
app-page-tur..prod.js gzip 94.9 kB 94.9 kB ✓
app-page-tur..prod.js gzip 89.5 kB 89.5 kB ✓
app-page.run...dev.js gzip 139 kB 139 kB ✓
app-page.run..prod.js gzip 88.8 kB 88.8 kB ✓
app-route-ex...dev.js gzip 24.1 kB 24.1 kB ✓
app-route-ex..prod.js gzip 16.7 kB 16.7 kB ✓
app-route-tu..prod.js gzip 16.7 kB 16.7 kB ✓
app-route-tu..prod.js gzip 16.3 kB 16.3 kB ✓
app-route.ru...dev.js gzip 23.5 kB 23.5 kB ✓
app-route.ru..prod.js gzip 16.3 kB 16.3 kB ✓
pages-api-tu..prod.js gzip 9.38 kB 9.38 kB ✓
pages-api.ru...dev.js gzip 9.65 kB 9.65 kB ✓
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 22.6 kB 22.6 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 49.5 kB 49.5 kB ✓
Overall change 932 kB 932 kB ✓
Commit: 7482cdd

@ijjk
Copy link
Member

ijjk commented Jan 4, 2024 •
edited
Loading

Failing test suites

Commit: 7482cdd

pnpm test-dev test/development/app-hmr/hmr.test.ts

  • app-dir-hmr > filesystem changes > should not break when renaming a folder
Expand output

● app-dir-hmr › filesystem changes › should not break when renaming a folder

TIMED OUT: success

undefined

Error: elementHandle.innerText: Element is not attached to the DOM

  626 |
  627 |   if (hardError) {
> 628 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  629 |   }
  630 |   return false
  631 | }

  at check (lib/next-test-utils.ts:628:11)
  at Object.<anonymous> (development/app-hmr/hmr.test.ts:44:11)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/app/index.test.ts

  • app dir - basic > bootstrap scripts > should successfully bootstrap even when using CSP
Expand output

● app dir - basic › bootstrap scripts › should successfully bootstrap even when using CSP

expect(received).toBe(expected) // Object.is equality

Expected: "[[updated]]"
Received: "initial"

  1841 |           expect(
  1842 |             await browser.eval('document.getElementById("val").textContent')
> 1843 |           ).toBe('[[updated]]')
       |             ^
  1844 |         })
  1845 |       } else {
  1846 |         it('should fail to bootstrap when using CSP in Dev due to eval', async () => {

  at Object.toBe (e2e/app-dir/app/index.test.ts:1843:13)

Read more about building and testing Next.js in contributing.md.

@styfle styfle merged commit a7be8ea into canary Jan 4, 2024
@styfle styfle deleted the NEXT-1974 branch January 4, 2024 22:37
@samcx samcx mentioned this pull request Jan 6, 2024
Closed
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
@styfle @agustints
fix: add node-web-audio-api to server-external-packages.json (verce…
f9637f0 
…l#60243)

This package contains native `.node` files that cannot be bundled

Closes NEXT-1974
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@styfle @ijjk