Make sure that 404's is not cached by CDN:s#5088
Merged
timneutkens merged 1 commit intovercel:canaryfrom Sep 4, 2018
Merged
Conversation
timneutkens
approved these changes
Sep 4, 2018
trashhalo
pushed a commit
to trashhalo/next.js
that referenced
this pull request
Sep 7, 2018
This got added in canary12 of 7.0.0 vercel#5088. but we can't wait for that version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Cloudflare will cache this for 5 minutes which may causes broken user sessions when where is a 404 returned during multiple nodes upgrading to the new asset