Conversation
chabou
reviewed
May 20, 2017
webpack.config.js
Outdated
|
|
||
| module.exports = { | ||
| devtool: isProd ? 'hidden-source-map' : 'cheap-eval-source-map', | ||
| devtool: isProd ? 'hidden-source-map' : 'inline-source-map', |
Contributor
There was a problem hiding this comment.
Maybe better to use cheap-module-source-map regarding to issue in webpack that you linked in this Electron issue
Contributor
Author
|
Done @chabou 🎉 |
chabou
suggested changes
May 20, 2017
Contributor
|
You're right! I can't reproduce #1738 anymore with this source-map format change. |
Member
|
This is awesome work! |
Contributor
Author
chabou
approved these changes
May 20, 2017
Contributor
Author
|
Let's merge when the tests are done 😎 |
This was referenced May 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looked at #1738 etc, turns out the eval problem was easy to work around (it was because of
cheap-eval-source-map), with this change source-maps still work 👌 🙌Latest electron uses node 7.4, so we still need the
--harmony-async-await(right? 🤔 ) for plugin compatibility.Tested on macOS and seems to work as before.
need to check with windows...
This should give some nice memory optimizations etc. 💯