-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Electron v1.6.x compatibility #1738
Copy link
Copy link
Closed
Description
I'm on MacOS
Master is currently was broken because of electron upgrade in this commit
HTR:
- Checkout master and resintall dependencies (
rm -Rf node_modules && yarn) - Launch Hyper (
npm run devandnpm run app) - Open DevTools
- Hit
ctrlkey
It sounds crazy because code (and const cache declaration) is ok. I have checked with electron v1.4.16 and everything is allright!
I studied this issue in depth and I found a closure problem with isAccelerator function.
With v1.4.16:

But with 1.6.6 a closure (with cache variable) is missing:

I don't know yet if it is a V8 issue (I strongly doubt that).
But I found an Electron related issue: webpack use some eval
If this issue is confirmed, due to its nature, we can suppose there is another issues with this same scope cause. I would recommend to stick to stable release channel of electron (v1.4.16).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
