Merged
Conversation
Contributor
|
Thank you for the nice words, Blake :) I am not really familiar with Typescript, but I am all for this. Maybe @timneutkens, @leo or @javivelasco can comment on the validity (though I'd go out on a limb to say you probably know what you're talking about 😉). |
timneutkens
approved these changes
Dec 10, 2018
Member
timneutkens
left a comment
There was a problem hiding this comment.
What an incredible type definition, I haven't used Typescript that much, but the definition seems to be fine, so ✅
Member
|
Sounds great and I need it now! |
javivelasco
approved these changes
Dec 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I love the simplicity of this project and want to start adopting it across the projects I maintain (replacing minimist). Providing a TypeScript definition will make adoption a lot easier by adding type safety in any strictly typed projects. Additionally, anyone using VS Code (and other editors with
.d.tssupport) with JavaScript will appreciate the automatic type output. It works by mapping over the "spec" type and producing the types according to the function return type (e.g.Stringis(x: string) => stringand it'll pick outstringfrom the return type).