fix(amazon-bedrock): preserve reasoning text when signature is present#13972
Merged
fix(amazon-bedrock): preserve reasoning text when signature is present#13972
Conversation
gr2m
reviewed
Mar 31, 2026
gr2m
approved these changes
Mar 31, 2026
gr2m
reviewed
Mar 31, 2026
packages/amazon-bedrock/src/convert-to-bedrock-chat-messages.test.ts
Outdated
Show resolved
Hide resolved
gr2m
reviewed
Mar 31, 2026
gr2m
reviewed
Mar 31, 2026
packages/amazon-bedrock/src/convert-to-bedrock-chat-messages.test.ts
Outdated
Show resolved
Hide resolved
gr2m
reviewed
Mar 31, 2026
packages/amazon-bedrock/src/convert-to-bedrock-chat-messages.test.ts
Outdated
Show resolved
Hide resolved
lgrammel
approved these changes
Mar 31, 2026
vercel-ai-sdk bot
pushed a commit
that referenced
this pull request
Mar 31, 2026
#13972) ## background `trimIfLast()` trims trailing whitespace from reasoning block text even when a cryptographic `signature` is present. the signature is computed over the exact original bytes - trimming even a single trailing newline invalidates the text/signature pair, causing Bedrock to reject with `ValidationException: thinking blocks cannot be modified` ## summary - skip `trimIfLast` for reasoning blocks that have a signature - reasoning blocks without a signature still get trimmed as before - add test for multi-turn tool use with signed reasoning blocks ## checklist - [x] tests have been added / updated (for bug fixes / features) - [ ] documentation has been added / updated (for bug fixes / features) - [x] a _patch_ changeset for relevant packages has been added (run `pnpm changeset` in root) - [x] i have reviewed this pull request (self-review) ## related issues fixes #13583
Contributor
|
✅ Backport PR created: #13979 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
background
trimIfLast()trims trailing whitespace from reasoning block text even when a cryptographicsignatureis present. the signature is computed over the exact original bytes - trimming even a single trailing newline invalidates the text/signature pair, causing Bedrock to reject withValidationException: thinking blocks cannot be modifiedsummary
trimIfLastfor reasoning blocks that have a signaturechecklist
pnpm changesetin root)related issues
fixes #13583