feat(ai): introduce experimental callbacks for embed function#13478
Merged
aayush-kapoor merged 14 commits intomainfrom Mar 18, 2026
Merged
feat(ai): introduce experimental callbacks for embed function#13478aayush-kapoor merged 14 commits intomainfrom
aayush-kapoor merged 14 commits intomainfrom
Conversation
lgrammel
reviewed
Mar 16, 2026
lgrammel
reviewed
Mar 16, 2026
lgrammel
reviewed
Mar 16, 2026
lgrammel
reviewed
Mar 16, 2026
| * | ||
| * Called when the operation begins, before the embedding model is called. | ||
| */ | ||
| export interface EmbedOnStartEvent { |
Collaborator
There was a problem hiding this comment.
when this is integrated into telemetry, some of the telemetry method names might need to change
Collaborator
Author
There was a problem hiding this comment.
yeah, might need to come up with a good nomenclature. worth discussing in the follow up PR
lgrammel
reviewed
Mar 16, 2026
lgrammel
reviewed
Mar 16, 2026
lgrammel
reviewed
Mar 16, 2026
…into aayush/embed-callbacks
4 tasks
lgrammel
reviewed
Mar 18, 2026
| @@ -17,9 +17,9 @@ | |||
| /** | |||
| * Common model information used across callback events. | |||
Collaborator
There was a problem hiding this comment.
also file still called callback-events -- maybe generate-text-events?
Collaborator
Author
There was a problem hiding this comment.
these are used by stream text as well.. how about core-events?
lgrammel
reviewed
Mar 18, 2026
Comment on lines
+20
to
25
| export interface ModelEventInfo { | ||
| /** The provider identifier (e.g., 'openai', 'anthropic'). */ | ||
| readonly provider: string; | ||
| /** The specific model identifier (e.g., 'gpt-4o'). */ | ||
| readonly modelId: string; | ||
| } |
Collaborator
There was a problem hiding this comment.
we have this already somewhere in the codebase afaik. if not it is worth having more general, e.g. as standalone ModelInfo (dont like info but good enough until we have a better name)
lgrammel
reviewed
Mar 18, 2026
|
|
||
| /** The model being used for generation. */ | ||
| readonly model: CallbackModelInfo; | ||
| readonly model: ModelEventInfo; |
Collaborator
There was a problem hiding this comment.
why do we have ModelEventInfo to begin with? can it be flattened?
lgrammel
reviewed
Mar 18, 2026
| @@ -0,0 +1,104 @@ | |||
| import type { JSONValue } from '@ai-sdk/provider'; | |||
| import type { ProviderOptions } from '@ai-sdk/provider-utils'; | |||
| import type { ModelEventInfo } from '../generate-text/callback-events'; | |||
Collaborator
There was a problem hiding this comment.
the dependency on generate-text seems strange. can we flatten the object into the events? or extract it into some other folder?
lgrammel
approved these changes
Mar 18, 2026
Contributor
|
🚀 Published in:
|
4 tasks
Contributor
|
|
aayush-kapoor
added a commit
that referenced
this pull request
Mar 19, 2026
…on (#13637) This is an automated backport of #13478 to the release-v6.0 branch. FYI @aayush-kapoor This backport has conflicts that need to be resolved manually. ### `git cherry-pick` output ``` Auto-merging content/docs/03-ai-sdk-core/65-event-listeners.mdx Auto-merging packages/ai/src/embed/embed-many.test.ts Auto-merging packages/ai/src/embed/embed.test.ts CONFLICT (content): Merge conflict in packages/ai/src/embed/embed.test.ts Auto-merging packages/ai/src/generate-text/callback-events.ts error: could not apply ff9ce30... feat(ai): introduce experimental callbacks for embed function (#13478) hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". hint: Disable this message with "git config set advice.mergeConflict false" ``` --------- Co-authored-by: Aayush Kapoor <83492835+aayush-kapoor@users.noreply.github.com> Co-authored-by: Aayush Kapoor <aayushkapoor34@gmail.com>
aayush-kapoor
added a commit
that referenced
this pull request
Mar 19, 2026
## Background as a follow up to this PR #13478, specifically [this comment](#13478 (comment)), there was uneccessary convolution of the data ## Summary - flatten the `model: {provider, modelId}` to be `provider` and `modelId` individually - rename `callback-events.ts` to `core-events.ts` ## Manual Verification na ## Checklist - [x] Tests have been added / updated (for bug fixes / features) - [ ] Documentation has been added / updated (for bug fixes / features) - [x] A _patch_ changeset for relevant packages has been added (for bug fixes / features - run `pnpm changeset` in the project root) - [x] I have reviewed this pull request (self-review) --------- Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
4 tasks
aayush-kapoor
added a commit
that referenced
this pull request
Mar 20, 2026
## Background the changes from #13478 were backported when they shouldn't have been. ## Summary cherry pick and revert all the changes ## Manual Verification na ## Checklist - [x] Tests have been added / updated (for bug fixes / features) - [x] Documentation has been added / updated (for bug fixes / features) - [x] A _patch_ changeset for relevant packages has been added (for bug fixes / features - run `pnpm changeset` in the project root) - [x] I have reviewed this pull request (self-review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In order to completely decouple OTel from the
aipackage, we need to align all the core functions to emit event data at each step for each of the functions.We made similar changes to generateText and streamText when we introduced
experimental_*(onStart, onStepStart, onFinish etc) and the same changes/callbacks needed to be added for the embed functionSummary
onStartandonFinishcallbacks (experimental)embedandembedManyManual Verification
na
Checklist
pnpm changesetin the project root)Future Work
decouple otel from the embed and embedMany function and move integration to
open-telemetry-integration