Add gluecose conformance tests#19
Merged
SteveLasker merged 3 commits intoveraison:mainfrom Mar 29, 2022
Merged
Conversation
555702e to
cfab627
Compare
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
49c9839 to
4d621e9
Compare
Contributor
Member
Author
|
@SteveLasker @thomas-fossati this is ready to merge. |
Closed
Contributor
thomas-fossati
left a comment
There was a problem hiding this comment.
Awesome work, 🚢 it!
thomas-fossati
approved these changes
Mar 29, 2022
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR checks in several conformance samples from https://github.com/gluecose/test-vectors and test that go-cose can sign and verify them.
Additionally, if the sample allows it, our CBOR output is compared against the sample output.
This new test suite deprecates all tests contained in sign_verify_cose_wg_examples_test.go, which were difficult to run and only did partial validations.