Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
- Coverage 92.81% 92.17% -0.65%
==========================================
Files 9 14 +5
Lines 306 894 +588
==========================================
+ Hits 284 824 +540
- Misses 16 52 +36
- Partials 6 18 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
72146bc to
9d6c1b5
Compare
|
LGTM! I can't approve. |
f7b9da0 to
f21923c
Compare
f21923c to
2c6744c
Compare
f792a63 to
c9e5c38
Compare
|
I'm interested in this @veqryn. Does what I'm looking for with gRPC. Think this'll go anywhere soon? 🙏🏼 |
Owner
Author
|
Heh, we are using it in production for a while now. I just forgot about merging it. I think I wanted to add a bit more test coverage or documentation or something. Will look into it this weekend hopefully. |
|
Awesome! Yes please. Staying tuned. Thank you
…On Thu, Mar 13, 2025 at 6:15 PM Chris Duncan ***@***.***> wrote:
Heh, we are using it in production for a while now. I just forgot about
merging it. I think I wanted to add a bit more test coverage or
documentation or something. Will look into it this weekend hopefully.
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQ3HSUQYQ32UUQNB2MHGOT2UH7PJAVCNFSM6AAAAABTYF7ZYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRSHAYDEOJZGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: veqryn]*veqryn* left a comment (veqryn/slog-context#24)
<#24 (comment)>
Heh, we are using it in production for a while now. I just forgot about
merging it. I think I wanted to add a bit more test coverage or
documentation or something. Will look into it this weekend hopefully.
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQ3HSUQYQ32UUQNB2MHGOT2UH7PJAVCNFSM6AAAAABTYF7ZYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRSHAYDEOJZGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Owner
Author
|
@jaredscheib hey! Sorry for the delay again. I added a couple missing features and quite a bit of documentation, and merged. |
|
Awesome! Thanks so much. Aiming to try it out soon and will update you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create slogctx grpc interceptors for server/client and unary/streaming.