Fix a bug with has-one relationship authorizers#124
Merged
valscion merged 1 commit intovenuu:masterfrom Mar 29, 2019
Merged
Conversation
Getting sent to has-one relationship authorizers
Member
|
Thanks! One way to go about without stubbing things could be to create some sort of minitest-like spec where all the relevant classes would be defined in the test file itself. Then those tests could go through all the layers without relying on any stubbing mechanisms. Even having one such test would be a huge boon to the development ability. I'd be interested to see how it would look like with minitest. RSpec would be also be OK. If only we could have all the relevant classes under test defined in the same file, that'd be nice — once that file gets unwieldy, we could figure out how to split it. |
valscion
approved these changes
Mar 29, 2019
Member
|
I released this as v3.0.1 — and would be amazing to have tests that wouldn't rely on stubbing 😅 |
brianswko
added a commit
to brianswko/jsonapi-authorization
that referenced
this pull request
Oct 2, 2019
Getting sent to has-one relationship authorizers
brianswko
added a commit
to brianswko/jsonapi-authorization
that referenced
this pull request
Oct 2, 2019
This reverts commit 9e35eb2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #119
Any has-one relationship authorizers e.g.
ArticlePolicy#create_with_author?(author)are currently breaking since the default authorizer is calling the method with[author]instead ofauthor.I was trying to be too clever in that PR simplifying code and didn't realize that there may be code elsewhere that relied on has-one relationships sending related records back as an actual record instead of potentially a single-object array.
I'd like to add a spec to cover this case since there are no (non-stub setup reliant) specs covering this behavior, but am unsure how to structure it. I believe this can go out on its own now, or am happy to take some feedback as to where to add a test for this.
While there was a major version bump to signify breaking changes, this was not an intended breaking change.