Skip to content

Conversation

@caesay
Copy link
Member

@caesay caesay commented Dec 30, 2024

Closes #395

@codecov
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.18%. Comparing base (da27736) to head (02e1e09).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/vpk/Velopack.Packaging.Windows/CodeSign.cs 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #435      +/-   ##
===========================================
+ Coverage    40.17%   40.18%   +0.01%     
===========================================
  Files          222      222              
  Lines        16213    16217       +4     
  Branches      1957     1957              
===========================================
+ Hits          6513     6517       +4     
  Misses        9366     9366              
  Partials       334      334              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caesay caesay merged commit 7fb6305 into develop Dec 30, 2024
25 checks passed
@caesay caesay deleted the cs/signing branch December 30, 2024 13:15
AArnott pushed a commit to nerdcash/Nerdbank.Cryptocurrencies that referenced this pull request Jan 4, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [vpk](https://github.com/velopack/velopack) | nuget | patch | `0.0.831-gde49887` -> `0.0.1053` |

---

### Release Notes

<details>
<summary>velopack/velopack (vpk)</summary>

### [`v0.0.1053`](https://github.com/velopack/velopack/releases/tag/0.0.1053)

[Compare Source](velopack/velopack@0.0.1049...0.0.1053)

#### What's Changed

-   Replace AuthenticodeTools with Microsoft.Security.Extensions by [@&#8203;caesay](https://github.com/caesay) in velopack/velopack#435
-   Roll custom GitHub http client to fix timeout issue by [@&#8203;caesay](https://github.com/caesay) in velopack/velopack#436

**Full Changelog**: velopack/velopack@0.0.1049...0.0.1053

### [`v0.0.1049`](https://github.com/velopack/velopack/releases/tag/0.0.1049)

[Compare Source](velopack/velopack@0.0.1023...0.0.1049)

#### What's Changed

-   Refactor publish/flow commands by [@&#8203;caesay](https://github.com/caesay) in velopack/velopack#423
-   possibly fix the github timeout issue by [@&#8203;caesay](https://github.com/caesay) in velopack/velopack#432
-   Critical: Fix dotnet cdn url; also add "dotnet-sdk" support and vcredist144 by [@&#8203;caesay](https://github.com/caesay) in velopack/velopack#434

#### Dependency Updates

<details>

<summary>Expand to see all changed dependencies</summary>

-   Update Rust crate serde to v1.0.217 by [@&#8203;renovate](https://github.com/renovate) in velopack/velopack#430
-   Update Rust crate serde to v1.0.217 by [@&#8203;renovate](https://github.com/renovate) in velopack/velopack#429
-   Lock file maintenance by [@&#8203;renovate](https://github.com/renovate) in velopack/velopack#433

</details>

**Full Changelog**: velopack/velopack@0.0.1023...0.0.1049

### [`v0.0.1023`](https://github.com/velopack/velopack/releases/tag/0.0.1023)

[Compare Source](velopack/velopack@0.0.1015...0.0.1023)

#### What's Changed

-   Disabling signing tests from PRs on remote forks by [@&#8203;Keboo](https://github.com/Keboo) in velopack/velopack#420
-   Bug fix for dialog shown by Update.exe when delta patch fails

#### Dependency Updates

<details>

<summary>Expand to see all changed dependencies</summary>

-   Lock file maintenance by [@&#8203;renovate](https://github.com/renovate) in velopack/velopack#421
-   Update dependency velopack to ^0.0.1015 by [@&#8203;renovate](https://github.com/renovate) in velopack/velopack#425
-   Update sample dotnet packages to 0.0.1015 by [@&#8203;renovate](https://github.com/renovate) in velopack/velopack#427
-  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace AuthenticodeTools with Microsoft.Security.Extensions

2 participants