Merged
Conversation
- Codebase minor clean up = Return error `405` (*was `401`*) when attempt to remove file from client-features with disabled `.remove()` on the Client
Add additional argument against using `gridfs-stream`. Update links to point to mongodb driver version 3.6. Use `MongoInternals.NpmModules.mongodb.modules` since `MongoInternals.NpmModule` is undocumented (see for instance https://github.com/meteor/meteor/blob/1dbf57ac5f9c405ee6bab30a13e51a3966d4014e/packages/mongo/mongo_driver.js#L16-L29).
docs: Update GridFS articles
Update GridFS docs
Update gridfs-bucket-integration.md
Update gridfs-bucket-integration.md
Update gridfs-bucket-integration.md
Update gridfs-streaming.md
Add missing method
- Get `Accounts` and `Template` from `Package` global object
__Major changes:__ -⚠️ `FSName` now sanitized and limited to 28 symbols, no white-spaces allowed -⚠️ `fileId` now sanitized and limited to 20 symbols, no white-spaces allowed -⚠️ File extension now sanitized and limited to 20 symbols, no white-spaces allowed - 📦 Decouple `fs-extra`, use native node.js `fs` module - 👨💻 Add missing `isData` helper via #795, by @harryadel __Changes:__ - 👷♂️ Fix: #827, thanks to @aertms - 👷♂️ Fix: #832, thanks to @polygonwood - 👷♂️ Fix: #813, thanks to @Prinzhorn - 👨💻 Fix: #834, thanks to @bladerunner2020 - 📔 Fix: #803, thanks to @bartenra - 🏗 Sanitize inputs (`FSName`, `fileId`, `extension`) to avoid command injection - 📔 Improved documentation, special thanks to @Prinzhorn and @make-github-pseudonymous-again - 📔 GridFS documentation fix: #818 - 👷♂️ Utilize `Meteor._debug` where possible instead of `console.log` __Other:__ - 🤝 Compatibility with `meteor@2.7.3`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes:
FSNamenow sanitized and limited to 28 symbols, no white-spaces allowedfileIdnow sanitized and limited to 20 symbols, no white-spaces allowedfs-extra, use native node.jsfsmoduleisDatahelper via Add missing method #795, by @harryadelChanges:
FSName,fileId,extension) to avoid command injectionMeteor._debugwhere possible instead ofconsole.logOther:
meteor@2.7.3