Merged
Conversation
v2.0.0 Major update is out 🎉 __Major changes__: -⚠️ __[Deprecated]__ `streams` of `.insert()` method; - ☝️ `http` module raplcaed with `fetch` — *As suggested* in `meteor@2.0.0` release and `http` package being deprecated; - ☝️ `request-libcurl` replaced with `fetch` — As a fix for veliovgroup#781 and similar issues; -⚠️ __[removed]__ `file-type` library used to detect file-type (*file's mime-type*) based on "magic numbers". Now mime-type detected from data supplied by browser. __Regresion possible *upgrade with care* if your app rely on mime-type detected after file is fully uploaded to server, this change won't affect mime-type detected on the *Client* before file fully loaded to server__. __Improved__: - Pause/Resume logic when connection with server is interrupted (*no more missed chunks*); - Chunks deliverability, including retries if chunk was sent only partially. __Other changes__: - 🤝 Compatibility with `meteor@2.0.0`; - 📦 `ostrio:cookies@2.7.0`, *was `v2.6.1`*; - 📦 `fs-extra@9.1.0`, *was `v9.0.1`*; - 🖥 Update, refactor, and refine [demo app](https://github.com/veliovgroup/meteor-files-website); - 👨💻 Update [`meteor-files-autoform`](https://github.com/VeliovGroup/meteor-autoform-file) package; - 📋 Documentation refactoring.
v2.0.1 __New:__ - ✨ `config.disableSetTokenCookie` see veliovgroup#776 and veliovgroup#778 for details, thanks to @Kaczkazniszczenia __Changed:__ - 👨💻 Abort http-fetch requests when calling `.abort()`; - 👨💻 Make sure no other/delayed requests/responses executed;
Update .versions
Collaborator
|
I totally agree with your comment, that buckets are rather used to organize than to scale but then please add this to your PR because otherwise nobody knows why they should use buckets at all |
Contributor
Author
I think the first section explains what a bucket is quite well and links to the GridFSBucket docs
|
jankapunkt
approved these changes
Sep 15, 2021
dr-dimitru
approved these changes
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I understand the following statement is incorrect and does not make sense:
The number of buckets has nothing to do with scaling per se. If you store images you need an image bucket. If you store documents as well you can have a second bucket for documents. This is just the way files are organized (e.g. S3 also calls the highest level a bucket, which has keys of files). Or you could have a bucket per user or domain I guess. That's just the way files are organized. Even if you throw every file in a single bucket scaling via sharding is unaffected.
Or am I missing something? I'm just getting started with Meteor-Files and found this part of the GridFS docs confusing.