disableSetTokenCookie && getUser#778
Merged
dr-dimitru merged 5 commits intoveliovgroup:devfrom Feb 12, 2021
Merged
Conversation
Allow to disable cookie setter.
alow to redefine how collection will recognize user.
feel so wrong doing it manually
dr-dimitru
added a commit
that referenced
this pull request
Mar 1, 2021
Merged
dr-dimitru
added a commit
that referenced
this pull request
Mar 1, 2021
v2.0.1 __New:__ - ✨ `config.disableSetTokenCookie` see #776 and #778 for details, thanks to @Kaczkazniszczenia __Changed:__ - 👨💻 Abort http-fetch requests when calling `.abort()`; - 👨💻 Make sure no other/delayed requests/responses executed;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to issue: Load balancer and cookie proposal #776
A minimalist approach that allows you to write your own association of the user with a cookie. Two hooks added:
disableSetTokenCookie {Boolean} [Client] - If true it will disable code responsible for setting 'x_mtok' cookie.
getUser {Function} [Server] - defining this function causes the replacement of the algorithm to recognize the user on the basis of 'http request'
Answers to 'yet' not asked questions:
Using 'protected' to change the user recognition method does not allow you to skip searching for the user using the 'x_mtok' cookie (which may not even exist), but only overwrite the failed attempt. Besides, with the current setting the 'protected' method has too much responsibility, adding a second method that better suits some subset of responsibilities will make the code more readable.
Even if someone uses the default cookie 'x_mtok', it is set and refreshed for each collection separately. I haven't investigated whether these extra calculations are noticeable for cpu, however, regardless of the results, I think it would be a good practice to disable cookies for all but one collection.