ci: switch to supported node versions by domoritz · Pull Request #4084 · vega/vega

domoritz · 2025-06-16T14:26:53Z

See https://nodejs.org/en/about/previous-releases

domoritz · 2025-06-16T14:44:37Z

Welp, looks like node 24 crashes internally.

      # CanvasHandler should pick arc mark


      #
      # Fatal error in , line 0
      # Check failed: static_cast<int64_t>(amount_before) >= -delta.
      #
      #
      #
      #FailureMessage Object: 0x16b30f698
      ----- Native stack trace -----

       1: 0x104c7d064 node::NodePlatform::GetStackTracePrinter()::$_0::__invoke() [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
       2: 0x106418064 V8_Fatal(char const*, ...) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
       3: 0x10503ff8c v8::internal::Heap::OldArrayBufferBytes() [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
       4: 0x104dfcff4 v8::Isolate::AdjustAmountOfExternalAllocatedMemory(long long) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
       5: 0x104ba0900 napi_adjust_external_memory [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
       6: 0x127ba464c ImageBackend::destroySurface() [/Users/dominik/Developer/vega/node_modules/canvas/build/Release/canvas.node]
       7: 0x127ba3120 Backend::recreateSurface() [/Users/dominik/Developer/vega/node_modules/canvas/build/Release/canvas.node]
       8: 0x127bb5f94 napi_value__* Napi::InstanceWrap<Canvas>::WrappedMethod<&Canvas::SetHeight(Napi::CallbackInfo const&, Napi::Value const&)>(napi_env__*, napi_callback_info__*)::'lambda'()::operator()() const [/Users/dominik/Developer/vega/node_modules/canvas/build/Release/canvas.node]
       9: 0x127bb5ed0 napi_value__* Napi::InstanceWrap<Canvas>::WrappedMethod<&Canvas::SetHeight(Napi::CallbackInfo const&, Napi::Value const&)>(napi_env__*, napi_callback_info__*) [/Users/dominik/Developer/vega/node_modules/canvas/build/Release/canvas.node]
      10: 0x104ba0da8 v8impl::(anonymous namespace)::FunctionCallbackWrapper::Invoke(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      11: 0x104e2e80c v8::internal::FunctionCallbackArguments::CallOrConstruct(v8::internal::Tagged<v8::internal::FunctionTemplateInfo>, bool) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      12: 0x104e2e0dc v8::internal::Builtins::InvokeApiFunction(v8::internal::Isolate*, bool, v8::internal::DirectHandle<v8::internal::FunctionTemplateInfo>, v8::internal::DirectHandle<v8::internal::Object>, v8::base::Vector<v8::internal::DirectHandle<v8::internal::Object> const>, v8::internal::DirectHandle<v8::internal::HeapObject>) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      13: 0x1053661c8 v8::internal::Object::SetPropertyWithAccessor(v8::internal::LookupIterator*, v8::internal::DirectHandle<v8::internal::Object>, v8::Maybe<v8::internal::ShouldThrow>) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      14: 0x105367adc v8::internal::Object::SetProperty(v8::internal::LookupIterator*, v8::internal::DirectHandle<v8::internal::Object>, v8::internal::StoreOrigin, v8::Maybe<v8::internal::ShouldThrow>) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      15: 0x1050e6164 v8::internal::StoreIC::Store(v8::internal::Handle<v8::internal::Union<v8::internal::Smi, v8::internal::HeapNumber, v8::internal::BigInt, v8::internal::String, v8::internal::Symbol, v8::internal::Boolean, v8::internal::Null, v8::internal::Undefined, v8::internal::JSReceiver>>, v8::internal::Handle<v8::internal::Name>, v8::internal::DirectHandle<v8::internal::Object>, v8::internal::StoreOrigin) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      16: 0x1050e7d58 v8::internal::KeyedStoreIC::Store(v8::internal::Handle<v8::internal::Union<v8::internal::Smi, v8::internal::HeapNumber, v8::internal::BigInt, v8::internal::String, v8::internal::Symbol, v8::internal::Boolean, v8::internal::Null, v8::internal::Undefined, v8::internal::JSReceiver>>, v8::internal::Handle<v8::internal::Object>, v8::internal::DirectHandle<v8::internal::Object>) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      17: 0x1050ea064 v8::internal::Runtime_KeyedStoreIC_Miss(int, unsigned long*, v8::internal::Isolate*) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      18: 0x105ae9f74 Builtins_CEntry_Return1_ArgvOnStack_NoBuiltinExit [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      19: 0x1381e30ec
      20: 0x105a4cbec Builtins_InterpreterEntryTrampoline [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      21: 0x1381e5448
      22: 0x1381e56b4
      23: 0x105a4cbec Builtins_InterpreterEntryTrampoline [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      24: 0x105a4a8cc Builtins_JSEntryTrampoline [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      25: 0x105a4a570 Builtins_JSEntry [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      26: 0x104f76c58 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      27: 0x104f765bc v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::DirectHandle<v8::internal::Object>, v8::internal::DirectHandle<v8::internal::Object>, v8::base::Vector<v8::internal::DirectHandle<v8::internal::Object> const>) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      28: 0x10536624c v8::internal::Object::SetPropertyWithAccessor(v8::internal::LookupIterator*, v8::internal::DirectHandle<v8::internal::Object>, v8::Maybe<v8::internal::ShouldThrow>) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      29: 0x105367adc v8::internal::Object::SetProperty(v8::internal::LookupIterator*, v8::internal::DirectHandle<v8::internal::Object>, v8::internal::StoreOrigin, v8::Maybe<v8::internal::ShouldThrow>) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      30: 0x1050e6164 v8::internal::StoreIC::Store(v8::internal::Handle<v8::internal::Union<v8::internal::Smi, v8::internal::HeapNumber, v8::internal::BigInt, v8::internal::String, v8::internal::Symbol, v8::internal::Boolean, v8::internal::Null, v8::internal::Undefined, v8::internal::JSReceiver>>, v8::internal::Handle<v8::internal::Name>, v8::internal::DirectHandle<v8::internal::Object>, v8::internal::StoreOrigin) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      31: 0x1050e95e4 v8::internal::Runtime_StoreIC_Miss(int, unsigned long*, v8::internal::Isolate*) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      32: 0x105ae9f74 Builtins_CEntry_Return1_ArgvOnStack_NoBuiltinExit [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      33: 0x105bd1748 Builtins_SetNamedPropertyHandler [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      34: 0x105a4cbec Builtins_InterpreterEntryTrampoline [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      35: 0x105a4a8cc Builtins_JSEntryTrampoline [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      36: 0x105a4a570 Builtins_JSEntry [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      37: 0x104f76c58 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      38: 0x104f765bc v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::DirectHandle<v8::internal::Object>, v8::internal::DirectHandle<v8::internal::Object>, v8::base::Vector<v8::internal::DirectHandle<v8::internal::Object> const>) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      39: 0x10536624c v8::internal::Object::SetPropertyWithAccessor(v8::internal::LookupIterator*, v8::internal::DirectHandle<v8::internal::Object>, v8::Maybe<v8::internal::ShouldThrow>) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      40: 0x105367adc v8::internal::Object::SetProperty(v8::internal::LookupIterator*, v8::internal::DirectHandle<v8::internal::Object>, v8::internal::StoreOrigin, v8::Maybe<v8::internal::ShouldThrow>) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      41: 0x1050e6164 v8::internal::StoreIC::Store(v8::internal::Handle<v8::internal::Union<v8::internal::Smi, v8::internal::HeapNumber, v8::internal::BigInt, v8::internal::String, v8::internal::Symbol, v8::internal::Boolean, v8::internal::Null, v8::internal::Undefined, v8::internal::JSReceiver>>, v8::internal::Handle<v8::internal::Name>, v8::internal::DirectHandle<v8::internal::Object>, v8::internal::StoreOrigin) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      42: 0x1050e95e4 v8::internal::Runtime_StoreIC_Miss(int, unsigned long*, v8::internal::Isolate*) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      43: 0x105ae9f74 Builtins_CEntry_Return1_ArgvOnStack_NoBuiltinExit [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      44: 0x105bd1748 Builtins_SetNamedPropertyHandler [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      45: 0x105a4cbec Builtins_InterpreterEntryTrampoline [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      46: 0x105a4cbec Builtins_InterpreterEntryTrampoline [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      47: 0x105a4cbec Builtins_InterpreterEntryTrampoline [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      48: 0x105a4cbec Builtins_InterpreterEntryTrampoline [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      49: 0x105a4cbec Builtins_InterpreterEntryTrampoline [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      50: 0x105a4cbec Builtins_InterpreterEntryTrampoline [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      51: 0x1381cb36c
      52: 0x1381cdb84
      53: 0x105a4cbec Builtins_InterpreterEntryTrampoline [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      54: 0x105a4a8cc Builtins_JSEntryTrampoline [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      55: 0x105a4a570 Builtins_JSEntry [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      56: 0x104f76c58 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      57: 0x104f765bc v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::DirectHandle<v8::internal::Object>, v8::internal::DirectHandle<v8::internal::Object>, v8::base::Vector<v8::internal::DirectHandle<v8::internal::Object> const>) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      58: 0x104debfe8 v8::Function::Call(v8::Isolate*, v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      59: 0x104af1290 node::InternalMakeCallback(node::Environment*, v8::Local<v8::Object>, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context, v8::Local<v8::Value>) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      60: 0x104af1574 node::InternalMakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context, v8::Local<v8::Value>) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      61: 0x104b82bf8 node::Environment::CheckImmediate(uv_check_s*) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      62: 0x105a32ba0 uv__run_check [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      63: 0x105a2bbc0 uv_run [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      64: 0x104af1a98 node::SpinEventLoopInternal(node::Environment*) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      65: 0x104c42d70 node::NodeMainInstance::Run() [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      66: 0x104bb0e60 node::Start(int, char**) [/Users/dominik/.volta/tools/image/node/24.2.0/bin/node]
      67: 0x1867cab98 start [/usr/lib/dyld]
      sh: line 1: 83804 Trace/BPT trap: 5       tape 'test/**/*-test.js'
      npm error Lifecycle script `test` failed with error:
      npm error code 133
      npm error path /Users/dominik/Developer/vega/packages/vega-scenegraph
      npm error workspace vega-scenegraph@5.0.0
      npm error location /Users/dominik/Developer/vega/packages/vega-scenegraph
      npm error command failed
      npm error command sh -c tape 'test/**/*-test.js' && npm run xmllint

openhands-ai · 2025-06-16T14:47:19Z

Looks like there are a few issues preventing this PR from being merged!

GitHub Actions are failing:
- Test

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #4084

Feel free to include any additional details that might help me get this PR into a better state.

_{^{You can manage your notification settings}}

ci: switch to supported node versions

da1ec4e

domoritz requested a review from a team as a code owner June 16, 2025 14:26

drop node 24 for now

663f512

domoritz merged commit 56507e7 into main Jun 16, 2025
1 of 3 checks passed

domoritz deleted the dom/node branch June 16, 2025 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: switch to supported node versions#4084

ci: switch to supported node versions#4084
domoritz merged 2 commits intomainfrom
dom/node

domoritz commented Jun 16, 2025

Uh oh!

domoritz commented Jun 16, 2025

Uh oh!

openhands-ai bot commented Jun 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

domoritz commented Jun 16, 2025

Uh oh!

domoritz commented Jun 16, 2025

Uh oh!

openhands-ai bot commented Jun 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant