Conversation
Deploying vega with
|
| Latest commit: |
3441e7f
|
| Status: | 🚫 Build failed. |
Member
|
Nice, confirmed that swapping in native fetch makes sense after node 18 and lets us cut the bundle size. We may want to note a minimum node version in the readme or development docs if that's the case. |
Member
Author
|
Node 18 is the latest supported and it's also indicated in the package.json already. Might be enough. |
domoritz
added a commit
that referenced
this pull request
Mar 30, 2025
`mode` is already an argument to fetch (https://developer.mozilla.org/en-US/docs/Web/API/RequestInit#mode) so we need to change the name. Technically it's a breaking change but we had an option collision so I think we should consider this a fix. Plus v6 hasn't been out for long. Follow up for #4047
5 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.