Skip to content

fix: correct browser exports syntax#4039

Merged
domoritz merged 4 commits intomainfrom
dom/exports-cleanups
Mar 25, 2025
Merged

fix: correct browser exports syntax#4039
domoritz merged 4 commits intomainfrom
dom/exports-cleanups

Conversation

@domoritz
Copy link
Copy Markdown
Member

@domoritz domoritz commented Mar 25, 2025 •
edited
Loading

This removes UMD bundles from everything but vega.

@domoritz domoritz added this to the Vega 6.0 milestone Mar 25, 2025
@domoritz domoritz requested a review from lsh March 25, 2025 16:10
@domoritz domoritz requested a review from a team as a code owner March 25, 2025 16:10
@domoritz domoritz mentioned this pull request Mar 25, 2025
Closed
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 25, 2025

Deploying vega with  Cloudflare Pages  Cloudflare Pages

Latest commit: aec0263
Status:🚫  Build failed.

View logs

@domoritz domoritz requested a review from hydrosquall March 25, 2025 16:12
@domoritz
Copy link
Copy Markdown
Member Author

domoritz commented Mar 25, 2025

@hydrosquall I can't access the logs so not sure why the preview builds are not working. Could you help?

@domoritz
Copy link
Copy Markdown
Member Author

domoritz commented Mar 25, 2025

I'll merge so we can go ahead with the release. We can fix the preview builds later.

@domoritz domoritz merged commit 1992590 into main Mar 25, 2025
4 of 5 checks passed
@domoritz domoritz deleted the dom/exports-cleanups branch March 25, 2025 16:23
@hydrosquall
Copy link
Copy Markdown
Member

hydrosquall commented Mar 25, 2025 •
edited
Loading

These are the current log outputs. I changed the node build version to request v20 instead of v18, we can try that on future builds.


12:12:28.651 | $ PARCEL_BUILD_COMMIT_HASH=$(git rev-parse HEAD) parcel build --public-url /editor --no-scope-hoist index.html --public-url / --no-optimize --no-source-maps
-- | --
12:12:29.074 | tput: unknown terminal "unknown"
12:12:29.230 | Building...
12:12:34.660 | 🚨 Build failed.
12:12:34.672 |  
12:12:34.674 |  
12:12:34.674 | @parcel/core: Failed to resolve 'node:http' from
12:12:34.674 | '/opt/buildhome/repo/packages/vega-loader/node_modules/node-fetch/src/index.js'
12:12:34.675 | /opt/buildhome/repo/packages/vega-loader/node_modules/node-fetch/src/index.js:9:18
12:12:34.675 | 8 \|
12:12:34.675 | >  9 \| import http from 'node:http';
12:12:34.675 | >    \|                  ^^^^^^^^^^^
12:12:34.675 | 10 \| import https from 'node:https';
12:12:34.675 | 11 \| import zlib from 'node:zlib';
12:12:34.676 |  
12:12:34.676 |  
12:12:34.677 | @parcel/resolver-default: Node builtin polyfill "stream-http/" is not installed,
12:12:34.677 | but auto install is disabled.
12:12:34.677 |  
12:12:34.677 | /opt/buildhome/repo/packages/vega-loader/node_modules/node-fetch/src/index.js:9:18
12:12:34.677 | 8 \|
12:12:34.677 | >  9 \| import http from 'node:http';
12:12:34.677 | 💡 Install the "stream-http/" package with your package manager, and run
12:12:34.677 | Parcel again.
12:12:34.677 | >    \|                  ^^^^^^^^^^^ used here
12:12:34.677 | 📝 Learn more:

I'll look into figuring out log forwarding so that it's easier to debug these, thanks for the patience

@domoritz
Copy link
Copy Markdown
Member Author

domoritz commented Mar 25, 2025

Thank you.

I was hoping that the new exports here would make parcel pull in the browser version of Vega loader but it doesn't seem to be working yet.

@lsh lsh mentioned this pull request Mar 25, 2025
Merged
lsh added a commit that referenced this pull request Mar 27, 2025
@lsh
chore: v6.0.0 (#4040)
45ce765 
changes since v5.33.0


**monorepo**
* Vega is now ESM only! (via #4018) (Thanks @domoritz!)
* (fix) Correct browser export syntax (via #4039) (Thanks @domoritz!)
* (fix) Fix source maps (via #4041) (Thanks @domoritz!)
* (fix) handle string datetime in interpreter (via #4042) (Thanks
@domoritz!)

**vega-typings**
* Expose resetSVGDefIds (via #4012) (Thanks @domoritz!)

**docs**
* Update deps and datasets (via #4036) (Thanks @domoritz!)

---------

Signed-off-by: Lukas Hermann <1734032+lsh@users.noreply.github.com>
@hydrosquall
Copy link
Copy Markdown
Member

hydrosquall commented Mar 28, 2025

We can fix the preview builds later.

I think I have a solution here: #4044 (comment)

@domoritz domoritz mentioned this pull request Apr 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lsh lsh lsh approved these changes

@hydrosquall hydrosquall Awaiting requested review from hydrosquall

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Vega 6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@domoritz @hydrosquall @lsh