feat(editor): Add setting for using editor with expressionInterpreter enabled#1461
Merged
hydrosquall merged 2 commits intomasterfrom Jan 27, 2025
Merged
Conversation
b9917c9 to
6689d95
Compare
domoritz
approved these changes
Jan 26, 2025
src/components/renderer/renderer.tsx
Outdated
Comment on lines
146
to
151
| if (mode === Mode.VegaLite) { | ||
| // In vl mode, we compile Vega-Lite spec along with config to Vega spec | ||
| runtime = vega.parse(vegaSpec); | ||
| runtime = vega.parse(vegaSpec, {}, parseOptions); | ||
| } else { | ||
| runtime = vega.parse(vegaSpec, config as VgConfig); | ||
| runtime = vega.parse(vegaSpec, config as VgConfig, parseOptions); | ||
| } |
Member
There was a problem hiding this comment.
Could probably simplify this to mode === Mode.VegaLite ? {} : config
Member
Author
There was a problem hiding this comment.
Good idea, just pushed the change 👍
6689d95 to
8dffdc7
Compare
Member
Author
|
CI not passing seems to be unrelated to this diff (I opened a separate issue for it #1462 ). Would you recommend merging the new setting first, or doing the CI fix first? |
Member
|
I'm okay with either. Having a ci fix first would be nicer since then we can merge this one cleanly. |
8dffdc7 to
a6ea2ca
Compare
Member
Author
|
Fixed CI in #1463, merging this since the checks are green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
expressionInterpretermode enabled #1460Changes
vega-interpretertopackage.jsonexpressionInterpreterto the root redux state. (Open to naming this so it looks more like a boolean, but since the name is long already I figured this was OK to start), and wires up associated Redux boilerplate (reducers, action creators, etc)yarn format $(modified_files), so I left them as is.Testing
expressionInterpreteris slightly different.