Skip to content

build: Fix Lint and build CI job #1462

@hydrosquall

Description

@hydrosquall

Motivation

Currently, the Lint and build job is erroring on main (the last time it passes was in September). This makes our github action CI less helpful for QA'ing changes, since all tests and linting must be run locally instead.

Image

Potential fixes

  1. Make a change to vega-lite s this particular line in scales.ts reflects the suggested update. Note: vega/vega-lite@c0cf2ce#diff-6bb3d0398511968293bdbd56cf0f3d477cfe7330c4b45fb2bd3f1773f269136f handles this already, upgrading to a newer version of vega-lite might fix this automatically once a new release is available
  2. Change the tsc config so it only typechecks vega/editor source code, not contents of node_modules . This might be useful eventually, but if (1) is solved with a vega-lite version upgrade, this will be unnecessary.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions