-
Notifications
You must be signed in to change notification settings - Fork 107
Closed
Description
Motivation
Currently, the Lint and build job is erroring on main (the last time it passes was in September). This makes our github action CI less helpful for QA'ing changes, since all tests and linting must be run locally instead.
Potential fixes
- Make a change to
vega-lites this particular line in scales.ts reflects the suggested update. Note: vega/vega-lite@c0cf2ce#diff-6bb3d0398511968293bdbd56cf0f3d477cfe7330c4b45fb2bd3f1773f269136f handles this already, upgrading to a newer version of vega-lite might fix this automatically once a new release is available - Change the
tscconfig so it only typechecksvega/editorsource code, not contents ofnode_modules. This might be useful eventually, but if (1) is solved with a vega-lite version upgrade, this will be unnecessary.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels