Fix struct validation for multiple files#65
Closed
mikeschinkel wants to merge 1 commit intovburenin:masterfrom
Closed
Fix struct validation for multiple files#65mikeschinkel wants to merge 1 commit intovburenin:masterfrom
mikeschinkel wants to merge 1 commit intovburenin:masterfrom
Conversation
3 tasks
grivera64
added a commit
to grivera64/ifacemaker
that referenced
this pull request
Mar 15, 2025
This follows the structure of PR vburenin#65
Collaborator
|
Closing in favor of #72 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the following command line where
persistercontains files generated by sqlc, your latest commit in master fails to correctly generate the file./app/query.iface.gobecause it cannot find the structQueriesin the first.gofile.ifacemaker -f ./persister/*.go -s Queries -i DataStoreQueries -p app -o ./app/query.iface.goI moved the
if !validateStructType(...) {...}to after the for loop and passedallDeclaredTypesinstead oftypesand it allowed the file to be generated. I believe this is all that is needed for a fix.