Skip to content

Quick fix of failure when use libc allocator in daily CI.#521

Merged
madolson merged 1 commit into
valkey-io:unstablefrom
zhulipeng:quickfix-dailyci
May 20, 2024
Merged

Quick fix of failure when use libc allocator in daily CI.#521
madolson merged 1 commit into
valkey-io:unstablefrom
zhulipeng:quickfix-dailyci

Conversation

@zhulipeng

Copy link
Copy Markdown
Member

@zhulipeng

Copy link
Copy Markdown
Member Author

#502 is doing such kind of refactor, I can close it if we are going to fix this in #502.

Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com>

@madolson madolson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good quick fix.

@madolson

Copy link
Copy Markdown
Member

@madolson madolson merged commit 122cba5 into valkey-io:unstable May 20, 2024
@zhulipeng zhulipeng deleted the quickfix-dailyci branch May 21, 2024 01:22
adetunjii pushed a commit to adetunjii/valkey that referenced this pull request May 22, 2024
)

Make `sdsResize` logic align with `_sdsnewlen`, fix of
valkey-io#476.
Fix:

https://github.com/valkey-io/valkey/actions/runs/9143545732/job/25140329542#step:6:1505

https://github.com/valkey-io/valkey/actions/runs/9135654696/job/25123330670#step:6:1501

Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com>
Signed-off-by: Samuel Adetunji <adetunjithomas1@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants