Omit alldbs rule in ACL SAVE/LIST and CONFIG REWRITE for compatibility#3964
Merged
Conversation
Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
📝 WalkthroughWalkthroughThe PR modifies how ACL (Access Control List) selector descriptions represent database permissions. The core implementation change stops explicitly emitting the ChangesACL implicit alldbs representation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zuiderkwast
approved these changes
Jun 10, 2026
madolson
approved these changes
Jun 10, 2026
This was referenced Jun 11, 2026
zuiderkwast
pushed a commit
to valkey-io/valkey-doc
that referenced
this pull request
Jun 18, 2026
As per valkey-io/valkey#3721 and valkey-io/valkey#3964, omit `alldbs` rules and drop mentions of `sanitize-payload` and `skip-sanitize-payload` user flags. Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database-level ACL #2309 introduced
alldbsrule that was explicit for all users and because of that previous versions no longer had the ability to parse ACL strings produced by later versions.Omit
alldbsinACLDescribeSelector(), that is used inACL SAVE/LOADandCONFIG REWRITEcommand paths so that downgrades would be possible if new feature was not used (db=andresetdbsrules).Keep
ACL GETUSERcommand's output as is and returnalldbsindatabasesfield because of command's field-value format.Add test to check that
ACL LISTomits implicitalldbsand add check to existingACL SAVEandCONFIG REWRITEtests.Fixes #3915