Remove apt-get upgrade in clang-format job#3913
Merged
zuiderkwast merged 1 commit intoJun 4, 2026
Merged
Conversation
The clang-format job only needs clang-format-18, but apt-get upgrade -y upgrades every pre-installed package on the runner (firefox and others), which adds minutes to the job for no benefit. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR removes the ChangesWorkflow Optimization
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3913 +/- ##
============================================
+ Coverage 76.67% 76.68% +0.01%
============================================
Files 162 162
Lines 80728 80735 +7
============================================
+ Hits 61897 61911 +14
+ Misses 18831 18824 -7 🚀 New features to boost your workflow:
|
zuiderkwast
approved these changes
Jun 4, 2026
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Jun 5, 2026
This changes helps speed up the clang-format job. We don't really need to upgrade every pre-installed package on the runner (firefox and a bunch of other things the job never uses). Before this change: 2m 47s After this change: 31s Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Harkrishn Patro <h_patro@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @zuiderkwast for pointing this out. This changes helps speed up the clang-format job. We don't really need to upgrade every pre-installed package on the runner (firefox and a bunch of other things the job never uses).
Before this change: 2m 47s (Eg)
After this change: 31s (Eg)