Increase max proctitle length from 255 to 1024#3843
Merged
enjoy-binbin merged 1 commit intoJun 24, 2026
Conversation
255 is too short if valkey-server is being run from a long path, especially if many fields are included such as in the "Process title set as expected" test in `unit/other.tcl`, where the max length for the cmdline is 1024, so having the same number in both makes sense. Signed-off-by: Petr Khartskhaev <pkhartsk@redhat.com>
📝 WalkthroughWalkthroughThe ChangesBuffer Size Increase
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
Looks like this will solve #3832 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3843 +/- ##
============================================
- Coverage 76.65% 76.57% -0.09%
============================================
Files 162 162
Lines 80710 80710
============================================
- Hits 61871 61805 -66
- Misses 18839 18905 +66
🚀 New features to boost your workflow:
|
dvkashapov
approved these changes
May 27, 2026
dvkashapov
left a comment
Member
There was a problem hiding this comment.
LGTM, the actual bigger stack allocation would only happen if SPT.end - SPT.base is bigger than buf size
Contributor
Author
|
Can this be merged? |
enjoy-binbin
approved these changes
Jun 24, 2026
valkeyrie-ops Bot
pushed a commit
that referenced
this pull request
Jun 25, 2026
255 is too short if valkey-server is being run from a long path, especially if many fields are included such as in the "Process title set as expected" test in `unit/other.tcl`, where the max length for the cmdline is 1024, so having the same number in both makes sense. Closes #3832. Signed-off-by: Petr Khartskhaev <pkhartsk@redhat.com>
valkeyrie-ops Bot
pushed a commit
that referenced
this pull request
Jun 25, 2026
255 is too short if valkey-server is being run from a long path, especially if many fields are included such as in the "Process title set as expected" test in `unit/other.tcl`, where the max length for the cmdline is 1024, so having the same number in both makes sense. Closes #3832. Signed-off-by: Petr Khartskhaev <pkhartsk@redhat.com>
valkeyrie-ops Bot
pushed a commit
that referenced
this pull request
Jun 25, 2026
255 is too short if valkey-server is being run from a long path, especially if many fields are included such as in the "Process title set as expected" test in `unit/other.tcl`, where the max length for the cmdline is 1024, so having the same number in both makes sense. Closes #3832. Signed-off-by: Petr Khartskhaev <pkhartsk@redhat.com>
valkeyrie-ops Bot
pushed a commit
that referenced
this pull request
Jun 25, 2026
255 is too short if valkey-server is being run from a long path, especially if many fields are included such as in the "Process title set as expected" test in `unit/other.tcl`, where the max length for the cmdline is 1024, so having the same number in both makes sense. Closes #3832. Signed-off-by: Petr Khartskhaev <pkhartsk@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
255 is too short if valkey-server is being run from a long path, especially if many fields are included such as in the "Process title set as expected" test in
unit/other.tcl, where the max length for the cmdline is 1024, so having the same number in both makes sense.Closes #3832.