Fix off_t to int truncation in bio repl transfer size reporting by chx9 · Pull Request #3811 · valkey-io/valkey

chx9 · 2026-05-23T02:05:10Z

off_t (64-bit), but were read into int (32-bit) locals in genValkeyInfoString() and handleBioThreadFinishedRDBDownload().

This causes INFO replication to report negative master_sync_total_bytes during bio disk-based sync when RDB exceeds 2GB.

Fix: change the local variable types from int to off_t.

coderabbitai · 2026-05-23T02:05:23Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 57200a82-aed0-4d7f-bb40-20ee5e3df88e

📥 Commits

Reviewing files that changed from the base of the PR and between 05fa87d and 0203835.

📒 Files selected for processing (2)

src/replication.c
src/server.c

📝 Walkthrough

Walkthrough

Two replication code paths now use off_t instead of int for local transfer-size/read counters: the bio-thread RDB download state restore and the INFO replication transfer reporting.

Changes

Replication transfer statistics type widening

Layer / File(s)	Summary
Transfer statistics type widening `src/replication.c`, `src/server.c`	Local variables in bio-thread RDB download state restoration (`handleBioThreadFinishedRDBDownload()`) and INFO replication output reporting are changed from `int` to `off_t` to avoid truncation of large transfer byte counters.

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers:

enjoy-binbin
roshkhatri

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and accurately describes the main change: fixing truncation of off_t values to int in bio repl transfer size reporting.
Description check	✅ Passed	The description clearly explains the bug (truncation of 64-bit off_t to 32-bit int causing negative values), the affected functions, and the fix applied.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-05-23T04:05:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.72%. Comparing base (cce8f49) to head (0203835).

Additional details and impacted files

@@            Coverage Diff            @@
##           unstable    #3811   +/-   ##
=========================================
  Coverage     76.71%   76.72%           
=========================================
  Files           162      162           
  Lines         80704    80704           
=========================================
+ Hits          61914    61918    +4     
+ Misses        18790    18786    -4

Files with missing lines	Coverage Δ
src/replication.c	`86.07% <100.00%> (ø)`
src/server.c	`89.49% <100.00%> (-0.03%)`	⬇️

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

enjoy-binbin

thanks.

`off_t` (64-bit), but were read into `int` (32-bit) locals in `genValkeyInfoString()` and `handleBioThreadFinishedRDBDownload()`. This causes INFO replication to report negative `master_sync_total_bytes` during bio disk-based sync when RDB exceeds 2GB. Fix: change the local variable types from `int` to `off_t`. Signed-off-by: chx9 <lovelypiska@outlook.com>

…ey-io#3811) (#306) `off_t` (64-bit), but were read into `int` (32-bit) locals in `genValkeyInfoString()` and `handleBioThreadFinishedRDBDownload()`. This causes INFO replication to report negative `master_sync_total_bytes` during bio disk-based sync when RDB exceeds 2GB. Fix: change the local variable types from `int` to `off_t`. (cherry picked from commit b4ea71e) Signed-off-by: chx9 <lovelypiska@outlook.com> Co-authored-by: lovelypiska <lovelypiska@outlook.com>

…ey-io#3811) `off_t` (64-bit), but were read into `int` (32-bit) locals in `genValkeyInfoString()` and `handleBioThreadFinishedRDBDownload()`. This causes INFO replication to report negative `master_sync_total_bytes` during bio disk-based sync when RDB exceeds 2GB. Fix: change the local variable types from `int` to `off_t`. Signed-off-by: chx9 <lovelypiska@outlook.com> (cherry picked from commit b4ea71e)

…ng (valkey-io#3811)" This reverts commit b4ea71e.

…ey-io#3811) (#313) `off_t` (64-bit), but were read into `int` (32-bit) locals in `genValkeyInfoString()` and `handleBioThreadFinishedRDBDownload()`. This causes INFO replication to report negative `master_sync_total_bytes` during bio disk-based sync when RDB exceeds 2GB. Fix: change the local variable types from `int` to `off_t`. Signed-off-by: chx9 <lovelypiska@outlook.com> Co-authored-by: lovelypiska <lovelypiska@outlook.com>

…ey-io#3811) (#318) `off_t` (64-bit), but were read into `int` (32-bit) locals in `genValkeyInfoString()` and `handleBioThreadFinishedRDBDownload()`. This causes INFO replication to report negative `master_sync_total_bytes` during bio disk-based sync when RDB exceeds 2GB. Fix: change the local variable types from `int` to `off_t`. Signed-off-by: chx9 <lovelypiska@outlook.com> Co-authored-by: lovelypiska <lovelypiska@outlook.com>

…ey-io#3811) (#322) `off_t` (64-bit), but were read into `int` (32-bit) locals in `genValkeyInfoString()` and `handleBioThreadFinishedRDBDownload()`. This causes INFO replication to report negative `master_sync_total_bytes` during bio disk-based sync when RDB exceeds 2GB. Fix: change the local variable types from `int` to `off_t`. Signed-off-by: chx9 <lovelypiska@outlook.com> Co-authored-by: lovelypiska <lovelypiska@outlook.com>

…ey-io#3811) (#326) `off_t` (64-bit), but were read into `int` (32-bit) locals in `genValkeyInfoString()` and `handleBioThreadFinishedRDBDownload()`. This causes INFO replication to report negative `master_sync_total_bytes` during bio disk-based sync when RDB exceeds 2GB. Fix: change the local variable types from `int` to `off_t`. Signed-off-by: chx9 <lovelypiska@outlook.com> Co-authored-by: lovelypiska <lovelypiska@outlook.com>

…ey-io#3811) `off_t` (64-bit), but were read into `int` (32-bit) locals in `genValkeyInfoString()` and `handleBioThreadFinishedRDBDownload()`. This causes INFO replication to report negative `master_sync_total_bytes` during bio disk-based sync when RDB exceeds 2GB. Fix: change the local variable types from `int` to `off_t`. Signed-off-by: chx9 <lovelypiska@outlook.com>

…ey-io#3811) (#333) `off_t` (64-bit), but were read into `int` (32-bit) locals in `genValkeyInfoString()` and `handleBioThreadFinishedRDBDownload()`. This causes INFO replication to report negative `master_sync_total_bytes` during bio disk-based sync when RDB exceeds 2GB. Fix: change the local variable types from `int` to `off_t`. Signed-off-by: chx9 <lovelypiska@outlook.com> Co-authored-by: lovelypiska <lovelypiska@outlook.com>

…ey-io#3811) (#337) `off_t` (64-bit), but were read into `int` (32-bit) locals in `genValkeyInfoString()` and `handleBioThreadFinishedRDBDownload()`. This causes INFO replication to report negative `master_sync_total_bytes` during bio disk-based sync when RDB exceeds 2GB. Fix: change the local variable types from `int` to `off_t`. Signed-off-by: chx9 <lovelypiska@outlook.com> Co-authored-by: lovelypiska <lovelypiska@outlook.com>

…ey-io#3811) (#342) `off_t` (64-bit), but were read into `int` (32-bit) locals in `genValkeyInfoString()` and `handleBioThreadFinishedRDBDownload()`. This causes INFO replication to report negative `master_sync_total_bytes` during bio disk-based sync when RDB exceeds 2GB. Fix: change the local variable types from `int` to `off_t`. Signed-off-by: chx9 <lovelypiska@outlook.com> Co-authored-by: lovelypiska <lovelypiska@outlook.com>

`off_t` (64-bit), but were read into `int` (32-bit) locals in `genValkeyInfoString()` and `handleBioThreadFinishedRDBDownload()`. This causes INFO replication to report negative `master_sync_total_bytes` during bio disk-based sync when RDB exceeds 2GB. Fix: change the local variable types from `int` to `off_t`. Signed-off-by: chx9 <lovelypiska@outlook.com>

chx9 force-pushed the fix/repl-off_t-truncation branch from 741e827 to 96d4ae5 Compare May 23, 2026 02:11

github-actions Bot assigned chx9 May 23, 2026

chx9 force-pushed the fix/repl-off_t-truncation branch from 96d4ae5 to 05fa87d Compare May 23, 2026 06:57

enjoy-binbin approved these changes May 24, 2026

View reviewed changes

enjoy-binbin requested a review from nitaicaro May 24, 2026 03:49

enjoy-binbin added this to Valkey 9.0 and Valkey 9.1 May 24, 2026

enjoy-binbin moved this to To be backported in Valkey 9.0 May 24, 2026

enjoy-binbin moved this to To be backported in Valkey 9.1 May 24, 2026

chx9 force-pushed the fix/repl-off_t-truncation branch from 05fa87d to 0203835 Compare May 25, 2026 03:19

zuiderkwast approved these changes Jun 12, 2026

View reviewed changes

zuiderkwast merged commit b4ea71e into valkey-io:unstable Jun 12, 2026
63 checks passed

valkeyrie-ops Bot mentioned this pull request Jun 14, 2026

[backport] Backport sweep for 9.1 #3970

Closed

valkeyrie-ops Bot mentioned this pull request Jun 17, 2026

[backport] Backport sweep for 9.1 #3987

Open

sarthakaggarwal97 pushed a commit to sarthakaggarwal97/valkey that referenced this pull request Jun 22, 2026

Revert "Fix off_t to int truncation in bio repl transfer size reporti…

9e42281

…ng (valkey-io#3811)" This reverts commit b4ea71e.

valkeyrie-ops Bot mentioned this pull request Jun 25, 2026

[backport] Backport sweep for 9.0 #3879

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix off_t to int truncation in bio repl transfer size reporting#3811

Fix off_t to int truncation in bio repl transfer size reporting#3811
zuiderkwast merged 1 commit into
valkey-io:unstablefrom
chx9:fix/repl-off_t-truncation

chx9 commented May 23, 2026

Uh oh!

coderabbitai Bot commented May 23, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

codecov Bot commented May 23, 2026 •

edited

Loading

Uh oh!

enjoy-binbin left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

chx9 commented May 23, 2026

Uh oh!

coderabbitai Bot commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

codecov Bot commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

enjoy-binbin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented May 23, 2026 •

edited

Loading

codecov Bot commented May 23, 2026 •

edited

Loading