src/modules/lua/script_lua.c (1)

766-773: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Drop the embedded ERR in the ACL rewrite.

This branch still constructs "ERR ACL failure in script: ..." and then passes it through luaPushError(), so it now comes out as ERR ERR ACL failure in script: .... Pass a bare message here, or -ERR ... if you want an explicit code preserved.

Suggested fix

-            const char *err_prefix = "ERR ACL failure in script: ";
+            const char *err_prefix = "ACL failure in script: ";
             size_t err_len = strlen(err_prefix) + strlen(err + strlen("NOPERM ")) + 1;
             char *err_msg = ValkeyModule_Alloc(err_len * sizeof(char));
             bzero(err_msg, err_len);
             strcpy(err_msg, err_prefix);
             strcat(err_msg, err + strlen("NOPERM "));
             luaPushError(lua, err_msg);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/modules/lua/script_lua.c` around lines 766 - 773, The code currently
builds an error string with the literal "ERR ACL failure in script: " then calls
luaPushError, causing a double "ERR ERR ..." output; change the constructed
prefix (err_prefix) to a bare message like "ACL failure in script: " (or to a
protocol-safe "-ERR ACL failure in script: " if you need an explicit code) so
luaPushError receives only the message body; update the err_len computation,
keep using ValkeyModule_Alloc/ValkeyModule_Free and strcat/strcpy as before, and
ensure the substring extraction (err + strlen("NOPERM ")) remains unchanged.

src/modules/lua/script_lua.c (1)

278-299: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Don't mutate err_buffer in the documented -CODE msg path.

Line 291 writes '\0' into err_buffer, but this function now explicitly documents "-CODE msg" as a supported input format while maintaining a const char * API contract. Although current callers (lines 786, 959) safely use mutable buffers from lm_asprintf(), the const-correctness violation is undefined behavior and will trap future callers who attempt to pass string literals or read-only memory. Parse the code without modifying caller memory.

Suggested fix

-    if (err_buffer[0] == '-') {
-        /* derive error code from the message */
-        char *err_msg = strstr(err_buffer, " ");
-        if (!err_msg) {
-            msg = lm_strcpy(err_buffer + 1);
-            final_msg = lm_asprintf("ERR %s", msg);
-        } else {
-            *err_msg = '\0';
-            msg = lm_strcpy(err_msg + 1);
-            msg = lm_strtrim(msg, "\r\n");
-            final_msg = lm_asprintf("%s %s", err_buffer + 1, msg);
-        }
+    if (err_buffer[0] == '-') {
+        /* Derive the explicit error code without mutating caller memory. */
+        const char *err_msg = strchr(err_buffer + 1, ' ');
+        if (!err_msg) {
+            msg = lm_strcpy(err_buffer + 1);
+            final_msg = lm_asprintf("ERR %s", msg);
+        } else {
+            size_t code_len = (size_t)(err_msg - (err_buffer + 1));
+            msg = lm_strcpy(err_msg + 1);
+            msg = lm_strtrim(msg, "\r\n");
+            final_msg = lm_asprintf("%.*s %s", (int)code_len, err_buffer + 1, msg);
+        }
     } else {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/modules/lua/script_lua.c` around lines 278 - 299, The code currently
mutates err_buffer by writing '\0' via *err_msg = '\0' when parsing the "-CODE
msg" form; instead, avoid modifying caller memory by locating the first space
(err_msg = strstr(err_buffer, " ")) and then extracting the code and message
into new strings or using pointer arithmetic without writes: copy the message
part with lm_strcpy/lm_strndup (e.g., copy from err_msg+1) and copy the code
part by creating a temporary string from err_buffer+1 up to the space (or use
lm_asprintf with a %.*s width), then lm_strtrim the copied message and build
final_msg with lm_asprintf("%s %s", code_copy, msg_copy); ensure all uses
reference the new copies (msg, code) and remove the in-place *err_msg = '\0'
mutation so err_buffer remains const-safe.