src/util.c (1)

1055-1063: ⚡ Quick win

Clarify the binary-safe rationale in the function comment.

The code now correctly hashes value_len bytes, but the comment doesn’t explain that this is required to preserve embedded \x00 bytes and avoid strlen() truncation regressions.

Proposed comment update

-/* Populate the provided seed array by hashing the provided string with SHA256
- * and copying the first outlen bytes of the digest into the seed buffer. */
+/* Populate the provided seed array by hashing arbitrary input bytes with SHA256.
+ * `value` may contain embedded NUL bytes, so callers must pass `value_len`
+ * explicitly (do not infer length with strlen()).
+ * Copy the first outlen bytes of the digest into the seed buffer. */

As per coding guidelines, "Document why code exists, not just what it does; document all functions in C code".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/util.c` around lines 1055 - 1063, Update the comment for
getHashSeedFromString to explain why it hashes exactly value_len bytes
(binary-safe) rather than relying on strlen(): explicitly state that the
function must preserve embedded '\x00' bytes in the input and avoid truncation
regressions, and that it computes SHA-256 over the provided byte length then
copies the first outlen bytes of the digest into seed_array; reference the
function name getHashSeedFromString and the use of
SHA256_CTX/sha256_init/sha256_update/sha256_final to make the rationale and
behavior clear.