fix compile warning in util.c#3585
Merged
Merged
Conversation
6c7cef4 to
b7f2a16
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3585 +/- ##
============================================
+ Coverage 76.42% 76.61% +0.18%
============================================
Files 159 159
Lines 80113 80115 +2
============================================
+ Hits 61225 61377 +152
+ Misses 18888 18738 -150
🚀 New features to boost your workflow:
|
madolson
reviewed
Apr 29, 2026
madolson
left a comment
Member
There was a problem hiding this comment.
The warning fix is valid, but this can be much simpler by reusing the existing VALKEY_NO_SANITIZE macro from config.h.
7049e0e to
1f22572
Compare
Member
Author
|
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
1f22572 to
a3dcb94
Compare
JimB123
commented
Apr 29, 2026
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
JimB123
commented
Apr 29, 2026
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
madolson
approved these changes
Apr 29, 2026
lucasyonge
pushed a commit
that referenced
this pull request
May 11, 2026
Address this compile warning:
```c
CC util.o
util.c:638:1: warning: ‘no_sanitize’ attribute directive ignored [-Wattributes]
__attribute__((no_sanitize_address, no_sanitize("thread"), used)) static int (*string2ll_resolver(void))(const char *, size_t, long long *) {
^~~~~~~~~~~~~
```
Addresses portability concerns around these attributes.
---------
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
lucasyonge
pushed a commit
that referenced
this pull request
May 12, 2026
Address this compile warning:
```c
CC util.o
util.c:638:1: warning: ‘no_sanitize’ attribute directive ignored [-Wattributes]
__attribute__((no_sanitize_address, no_sanitize("thread"), used)) static int (*string2ll_resolver(void))(const char *, size_t, long long *) {
^~~~~~~~~~~~~
```
Addresses portability concerns around these attributes.
---------
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address this compile warning:
Addresses portability concerns around these attributes.