Revert "Fail fast on invalid certificates at TLS config load (#2999)"#3572
Merged
madolson merged 1 commit intoApr 27, 2026
Merged
Conversation
murphyjacob4
approved these changes
Apr 27, 2026
yang-z-o
approved these changes
Apr 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 9.1 #3572 +/- ##
==========================================
- Coverage 74.57% 74.46% -0.11%
==========================================
Files 130 130
Lines 72731 72731
==========================================
- Hits 54239 54161 -78
- Misses 18492 18570 +78
🚀 New features to boost your workflow:
|
madolson
approved these changes
Apr 27, 2026
madolson
left a comment
Member
There was a problem hiding this comment.
Tests seem unrelated, we should be able to just merge this.
Member
|
Not going to wait for valgrind. |
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Apr 27, 2026
…o#3572) Revert of valkey-io#2999 (Prevent invalid TLS certificates from being loaded) was decided by TSC as it is a breaking change, deferred to next major. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
This was referenced May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit eb3f465.
As discussed in the TSC Core Meeting, this PR reverts #2999 from Valkey 9.1. We plan to do in next major version as it's a breaking change.
Note: Merge conflicts in
src/tls.cincludes were resolved due to overlapping changes from PR #2913, which addedtlsUpdateCertInfoFromDir()with shared header dependencies.