Rename redis_init_script file and its content#357
Merged
Conversation
Signed-off-by: hwware <wen.hui.ware@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #357 +/- ##
============================================
+ Coverage 68.33% 68.38% +0.05%
============================================
Files 108 108
Lines 61562 61562
============================================
+ Hits 42066 42101 +35
+ Misses 19496 19461 -35 |
zuiderkwast
approved these changes
Apr 24, 2024
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
We can mention the install script in the pr description too.
enjoy-binbin
approved these changes
Apr 24, 2024
hwware
pushed a commit
to valkey-io/valkey-doc
that referenced
this pull request
Apr 24, 2024
Fix docs for valkey-io/valkey#357 Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the init script and a related
.tplfile and rename variable names inside (redis to valkey). Update variables inutils/install_server.sh.Fixes #354