Fix GEOSEARCH BYPOLYGON leak on invalid COUNT#3568
Merged
Conversation
Signed-off-by: Su Ko <rhtn1128@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #3568 +/- ##
============================================
- Coverage 76.42% 76.40% -0.02%
============================================
Files 159 159
Lines 80113 80128 +15
============================================
- Hits 61225 61221 -4
- Misses 18888 18907 +19
🚀 New features to boost your workflow:
|
ranshid
reviewed
Apr 27, 2026
Signed-off-by: Su Ko <rhtn1128@gmail.com>
enjoy-binbin
left a comment
Member
There was a problem hiding this comment.
I don't know the details very well, however, the code structure makes it genuinely difficult to spot this issue. The most effective solution I can think of would likely be to add geoPolygonPointsFree to every error path. @KarthikSubbarao @bandalgomsu WDYT?
Also, we should perhaps standardize the usage of geoPolygonPointsFree here, rather than directly calling zfree(shape.t.polygon.points).
/* Extract polygon vertices. */
shape.conversion = 1;
shape.t.polygon.num_vertices = num_vertices;
shape.t.polygon.points = zmalloc(num_vertices * sizeof(double[2]));
for (int j = 0; j < num_vertices * 2; j += 2) {
if (extractLongLatOrReply(c, c->argv + base_args + i + 2 + j, shape.t.polygon.points[j / 2]) == C_ERR) {
zfree(shape.t.polygon.points);
return;
}
}
shape.type = POLYGON_TYPE;
Contributor
Author
|
I think adding
Make sense 👍 |
murphyjacob4
approved these changes
Apr 29, 2026
Signed-off-by: Su Ko <rhtn1128@gmail.com>
KarthikSubbarao
approved these changes
Apr 29, 2026
lucasyonge
approved these changes
Apr 29, 2026
This was referenced May 3, 2026
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
May 7, 2026
Free BYPOLYGON points before returning from invalid COUNT parsing paths in GEOSEARCH/GEOSEARCHSTORE. Closes valkey-io#3567 --------- Signed-off-by: Su Ko <rhtn1128@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
lucasyonge
pushed a commit
that referenced
this pull request
May 11, 2026
Free BYPOLYGON points before returning from invalid COUNT parsing paths in GEOSEARCH/GEOSEARCHSTORE. Closes #3567 --------- Signed-off-by: Su Ko <rhtn1128@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
lucasyonge
pushed a commit
that referenced
this pull request
May 12, 2026
Free BYPOLYGON points before returning from invalid COUNT parsing paths in GEOSEARCH/GEOSEARCHSTORE. Closes #3567 --------- Signed-off-by: Su Ko <rhtn1128@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
valkeyrie-ops Bot
pushed a commit
that referenced
this pull request
May 20, 2026
Free BYPOLYGON points before returning from invalid COUNT parsing paths in GEOSEARCH/GEOSEARCHSTORE. Closes #3567 --------- Signed-off-by: Su Ko <rhtn1128@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
valkeyrie-ops Bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
Free BYPOLYGON points before returning from invalid COUNT parsing paths in GEOSEARCH/GEOSEARCHSTORE. Closes #3567 --------- Signed-off-by: Su Ko <rhtn1128@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free BYPOLYGON points before returning from invalid COUNT parsing paths in GEOSEARCH/GEOSEARCHSTORE.
Closes #3567