Rename remaining test procedures missed in #287#355
Merged
zuiderkwast merged 2 commits intoApr 24, 2024
Conversation
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
#287
#287#287
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #355 +/- ##
============================================
- Coverage 68.37% 68.37% -0.01%
============================================
Files 108 108
Lines 61562 61562
============================================
- Hits 42092 42090 -2
- Misses 19470 19472 +2 |
enjoy-binbin
approved these changes
Apr 24, 2024
Contributor
|
And very good PR description! |
Contributor
Author
I re-run the workflow and now all the test passed. Thanks! |
WM0323
pushed a commit
to WM0323/valkey
that referenced
this pull request
Apr 26, 2024
Renamed below procedures and variables (missed in valkey-io#287) as follows. redis_cluster -> valkey_cluster redis1 -> valkey1 redis2 -> valkey2 get_redis_dir -> get_valkey_dir test_redis_cli_rdb_dump -> test_valkey_cli_rdb_dump test_redis_cli_repl -> test_valkey_cli_repl redis-cli -> valkey-cli redis_reset_state -> valkey_reset_state redisHandle -> valkeyHandle redis_safe_read -> valkey_safe_read redis_safe_gets -> valkey_safe_gets redis_write -> valkey_write redis_read_reply -> valkey_read_reply redis_readable -> valkey_readable redis_readnl -> valkey_readnl redis_writenl -> valkey_writenl redis_read_map -> valkey_read_map redis_read_line -> valkey_read_line redis_read_null -> valkey_read_null redis_read_bool -> valkey_read_bool redis_read_double -> valkey_read_double redis_read_verbatim_str -> valkey_read_verbatim_str redis_call_callback -> valkey_call_callback --------- Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com> Signed-off-by: Sher Sun <sher.sun@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed below procedures and variables as follows.
redis_cluster -> valkey_cluster
redis1 -> valkey1
redis2 -> valkey2
get_redis_dir -> get_valkey_dir
test_redis_cli_rdb_dump -> test_valkey_cli_rdb_dump
test_redis_cli_repl -> test_valkey_cli_repl
redis-cli -> valkey-cli
redis_reset_state -> valkey_reset_state
redisHandle -> valkeyHandle
redis_safe_read -> valkey_safe_read
redis_safe_gets -> valkey_safe_gets
redis_write -> valkey_write
redis_read_reply -> valkey_read_reply
redis_readable -> valkey_readable
redis_readnl -> valkey_readnl
redis_writenl -> valkey_writenl
redis_read_map -> valkey_read_map
redis_read_line -> valkey_read_line
redis_read_null -> valkey_read_null
redis_read_bool -> valkey_read_bool
redis_read_double -> valkey_read_double
redis_read_verbatim_str -> valkey_read_verbatim_str
redis_call_callback -> valkey_call_callback