Run ASan Tests on run-extra-tests label#3512
Merged
enjoy-binbin merged 4 commits intoMay 1, 2026
Merged
Conversation
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Member
|
Added the label to test it |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3512 +/- ##
============================================
- Coverage 76.66% 76.45% -0.22%
============================================
Files 159 159
Lines 80114 80114
============================================
- Hits 61423 61249 -174
- Misses 18691 18865 +174 🚀 New features to boost your workflow:
|
Nikhil-Manglore
approved these changes
Apr 15, 2026
Nikhil-Manglore
left a comment
Member
There was a problem hiding this comment.
Nice, this is a good addition
enjoy-binbin
approved these changes
Apr 16, 2026
Contributor
Author
|
@zuiderkwast @enjoy-binbin none of the sanitizer tests take too long to run (the longest is macos by quite some distance) and I feel it would be a great way to solve the issues before the PR is merged. We saw some issues lately which could have been caught if sanitizer runs were enabled. |
roshkhatri
approved these changes
Apr 28, 2026
roshkhatri
left a comment
Member
There was a problem hiding this comment.
Yes I think we should add this.
lucasyonge
pushed a commit
that referenced
this pull request
May 11, 2026
It's important to enabled ASAN on run-extra-tests label so we can catch some of the bugs in the PRs before they are merged into unstable. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
lucasyonge
pushed a commit
that referenced
this pull request
May 12, 2026
It's important to enabled ASAN on run-extra-tests label so we can catch some of the bugs in the PRs before they are merged into unstable. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's important to enabled ASAN on run-extra-tests label so we can catch some of the bugs in the PRs before they are merged into unstable.