Skip to content

Attempt to deflake 'diskless no replicas drop during rdb pipe'#3461

Merged
zuiderkwast merged 1 commit into
valkey-io:unstablefrom
zuiderkwast:deflake-diskless-no-replicas-drop-during-rdb-pipe
Apr 8, 2026
Merged

Attempt to deflake 'diskless no replicas drop during rdb pipe'#3461
zuiderkwast merged 1 commit into
valkey-io:unstablefrom
zuiderkwast:deflake-diskless-no-replicas-drop-during-rdb-pipe

Conversation

@zuiderkwast

@zuiderkwast zuiderkwast commented Apr 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Increase time to wait for bgsave to complete. This wait has been seen failing in these test cases.

The test case loops with 'no', 'slow', 'fast', 'all' and 'timeout' replicas, in tests/integration/replication.tcl

Example:

*** [err]: diskless fast replicas drop during rdb pipe in tests/integration/replication.tcl
rdb child didn't terminate

https://github.com/valkey-io/valkey/actions/runs/24110987718/job/70345236355#step:9:8083

@zuiderkwast
Attempt to deflake 'diskless no replicas drop during rdb pipe'
5480492 
in tests/integration/replication.tcl

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@zuiderkwast zuiderkwast added the run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP) label Apr 8, 2026
@codecov

codecov Bot commented Apr 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.53%. Comparing base (dba128f) to head (5480492).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #3461      +/-   ##
============================================
+ Coverage     76.52%   76.53%   +0.01%     
============================================
  Files           157      157              
  Lines         79035    79035              
============================================
+ Hits          60478    60487       +9     
+ Misses        18557    18548       -9

see 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zuiderkwast zuiderkwast marked this pull request as ready for review April 8, 2026 12:58
@zuiderkwast zuiderkwast merged commit f6b5461 into valkey-io:unstable Apr 8, 2026
74 of 108 checks passed
@zuiderkwast zuiderkwast deleted the deflake-diskless-no-replicas-drop-during-rdb-pipe branch April 8, 2026 13:06
@github-project-automation github-project-automation Bot moved this to To be backported in Valkey 8.1 Apr 8, 2026
@github-project-automation github-project-automation Bot moved this to To be backported in Valkey 7.2 Apr 8, 2026
@github-project-automation github-project-automation Bot moved this to To be backported in Valkey 8.0 Apr 8, 2026
@github-project-automation github-project-automation Bot moved this to To be backported in Valkey 9.0 Apr 8, 2026
@github-project-automation github-project-automation Bot moved this to To be backported in Valkey 9.1 Apr 8, 2026
@asagege

asagege commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@zuiderkwast Hey Viktor, I saw there are still failing tests saying 'diskless no replicas drop during rdb pipe', seems 1200 × 100ms = 120,000ms = 120 seconds still not enough.

Failed examples:
https://github.com/valkey-io/valkey/actions/runs/24336903424/job/71055903696#step:4:8316 (128 s)
https://github.com/valkey-io/valkey/actions/runs/24269802176/job/70872287996?pr=3350#step:4:8328 (125 s)

@zuiderkwast

zuiderkwast commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

@asagege Ah, yes, then we can increase it even more if the runners are just slow, or do you think it hangs forever for some reason?

@sarthakaggarwal97 sarthakaggarwal97 mentioned this pull request Apr 14, 2026
Closed
@Nikhil-Manglore Nikhil-Manglore mentioned this pull request Apr 15, 2026
Merged
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/valkey that referenced this pull request Apr 16, 2026
@zuiderkwast @sarthakaggarwal97
Attempt to deflake 'diskless no replicas drop during rdb pipe' (valke…
01e68d2 
…y-io#3461)

Increase time to wait for bgsave to start. This wait has been seen
failing in these test cases.

The test case loops with 'no', 'slow', 'fast', 'all' and 'timeout'
replicas, in tests/integration/replication.tcl

Example:

*** [err]: diskless fast replicas drop during rdb pipe in
tests/integration/replication.tcl
    rdb child didn't terminate

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@sarthakaggarwal97 sarthakaggarwal97 mentioned this pull request Apr 16, 2026
Merged
sarthakaggarwal97 added a commit to sarthakaggarwal97/valkey that referenced this pull request Apr 17, 2026
@sarthakaggarwal97
Deflake 'diskless no replicas drop during rdb pipe' (valkey-io#3461)
68d34ba 
Cherry-pick of f6b5461 from unstable.
Increases wait_for_condition timeout for rdb child termination.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97 added a commit to sarthakaggarwal97/valkey that referenced this pull request Apr 17, 2026
@sarthakaggarwal97
Deflake 'diskless no replicas drop during rdb pipe' (valkey-io#3461)
6bc339f 
Cherry-pick of f6b5461 from unstable.
Increases wait_for_condition timeout for rdb child termination.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97 added a commit to sarthakaggarwal97/valkey that referenced this pull request Apr 17, 2026
@sarthakaggarwal97
Deflake 'diskless no replicas drop during rdb pipe' (valkey-io#3461)
ec453d9 
Cherry-pick of f6b5461 from unstable.
Increases wait_for_condition timeout for rdb child termination.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97 added a commit to sarthakaggarwal97/valkey that referenced this pull request Apr 17, 2026
@sarthakaggarwal97
Deflake 'diskless no replicas drop during rdb pipe' (valkey-io#3461)
9e7f841 
Cherry-pick of f6b5461 from unstable.
Increases wait_for_condition timeout for rdb child termination.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97 added a commit to sarthakaggarwal97/valkey that referenced this pull request Apr 27, 2026
@sarthakaggarwal97
Deflake 'diskless no replicas drop during rdb pipe' (valkey-io#3461)
21bf23a 
Cherry-pick of f6b5461 from unstable.
Increases wait_for_condition timeout for rdb child termination.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 68d34ba)
sarthakaggarwal97 added a commit to sarthakaggarwal97/valkey that referenced this pull request Apr 27, 2026
@sarthakaggarwal97
Deflake 'diskless no replicas drop during rdb pipe' (valkey-io#3461)
c0abc55 
Cherry-pick of f6b5461 from unstable.
Increases wait_for_condition timeout for rdb child termination.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 6bc339f)
sarthakaggarwal97 added a commit to sarthakaggarwal97/valkey that referenced this pull request Apr 27, 2026
@sarthakaggarwal97
Deflake 'diskless no replicas drop during rdb pipe' (valkey-io#3461)
0b29e55 
Cherry-pick of f6b5461 from unstable.
Increases wait_for_condition timeout for rdb child termination.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit ec453d9)
sarthakaggarwal97 added a commit to sarthakaggarwal97/valkey that referenced this pull request Apr 27, 2026
@sarthakaggarwal97
Deflake 'diskless no replicas drop during rdb pipe' (valkey-io#3461)
c230763 
Cherry-pick of f6b5461 from unstable.
Increases wait_for_condition timeout for rdb child termination.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 9e7f841)
madolson pushed a commit that referenced this pull request Apr 27, 2026
@zuiderkwast @madolson
Attempt to deflake 'diskless no replicas drop during rdb pipe' (#3461)
926c755 
Increase time to wait for bgsave to start. This wait has been seen
failing in these test cases.

The test case loops with 'no', 'slow', 'fast', 'all' and 'timeout'
replicas, in tests/integration/replication.tcl

Example:

*** [err]: diskless fast replicas drop during rdb pipe in
tests/integration/replication.tcl
    rdb child didn't terminate

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
sarthakaggarwal97 added a commit to sarthakaggarwal97/valkey that referenced this pull request May 3, 2026
@sarthakaggarwal97
Deflake 'diskless no replicas drop during rdb pipe' (valkey-io#3461)
2876001 
Cherry-pick of f6b5461 from unstable.
Increases wait_for_condition timeout for rdb child termination.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit ec453d9)
sarthakaggarwal97 added a commit to sarthakaggarwal97/valkey that referenced this pull request May 3, 2026
@sarthakaggarwal97
Deflake 'diskless no replicas drop during rdb pipe' (valkey-io#3461)
a7b157a 
Cherry-pick of f6b5461 from unstable.
Increases wait_for_condition timeout for rdb child termination.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 9e7f841)
This was referenced May 4, 2026
Closed
Merged
madolson pushed a commit that referenced this pull request May 6, 2026
@sarthakaggarwal97 @madolson
Deflake 'diskless no replicas drop during rdb pipe' (#3461)
d84b75b 
Cherry-pick of f6b5461 from unstable.
Increases wait_for_condition timeout for rdb child termination.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 9e7f841)
@sarthakaggarwal97 sarthakaggarwal97 mentioned this pull request May 6, 2026
Merged
madolson pushed a commit that referenced this pull request May 6, 2026
@sarthakaggarwal97 @madolson
Deflake 'diskless no replicas drop during rdb pipe' (#3461)
8845cdf 
Cherry-pick of f6b5461 from unstable.
Increases wait_for_condition timeout for rdb child termination.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit ec453d9)
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/valkey that referenced this pull request May 7, 2026
@zuiderkwast
Attempt to deflake 'diskless no replicas drop during rdb pipe' (valke…
1ff8c06 
…y-io#3461)

Increase time to wait for bgsave to start. This wait has been seen
failing in these test cases.

The test case loops with 'no', 'slow', 'fast', 'all' and 'timeout'
replicas, in tests/integration/replication.tcl

Example:

*** [err]: diskless fast replicas drop during rdb pipe in
tests/integration/replication.tcl
    rdb child didn't terminate

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/valkey that referenced this pull request May 7, 2026
@zuiderkwast
Attempt to deflake 'diskless no replicas drop during rdb pipe' (valke…
9afc223 
…y-io#3461)

Increase time to wait for bgsave to start. This wait has been seen
failing in these test cases.

The test case loops with 'no', 'slow', 'fast', 'all' and 'timeout'
replicas, in tests/integration/replication.tcl

Example:

*** [err]: diskless fast replicas drop during rdb pipe in
tests/integration/replication.tcl
    rdb child didn't terminate

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@sarthakaggarwal97 sarthakaggarwal97 moved this from To be backported to Done in Valkey 9.1 May 16, 2026
valkeyrie-ops Bot pushed a commit that referenced this pull request May 18, 2026
@zuiderkwast
Attempt to deflake 'diskless no replicas drop during rdb pipe' (#3461)
110abfc 
Increase time to wait for bgsave to start. This wait has been seen
failing in these test cases.

The test case loops with 'no', 'slow', 'fast', 'all' and 'timeout'
replicas, in tests/integration/replication.tcl

Example:

*** [err]: diskless fast replicas drop during rdb pipe in
tests/integration/replication.tcl
    rdb child didn't terminate

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
valkeyrie-ops Bot pushed a commit that referenced this pull request May 18, 2026
@zuiderkwast
Attempt to deflake 'diskless no replicas drop during rdb pipe' (#3461)
da15541 
Increase time to wait for bgsave to start. This wait has been seen
failing in these test cases.

The test case loops with 'no', 'slow', 'fast', 'all' and 'timeout'
replicas, in tests/integration/replication.tcl

Example:

*** [err]: diskless fast replicas drop during rdb pipe in
tests/integration/replication.tcl
    rdb child didn't terminate

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
This was referenced May 20, 2026
Closed
Merged
zuiderkwast added a commit that referenced this pull request Jun 2, 2026
@zuiderkwast
Attempt to deflake 'diskless no replicas drop during rdb pipe' (#3461)
e068f8d 
Increase time to wait for bgsave to start. This wait has been seen
failing in these test cases.

The test case loops with 'no', 'slow', 'fast', 'all' and 'timeout'
replicas, in tests/integration/replication.tcl

Example:

*** [err]: diskless fast replicas drop during rdb pipe in
tests/integration/replication.tcl
    rdb child didn't terminate

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@zuiderkwast zuiderkwast moved this from To be backported to 8.1.8 (WIP) in Valkey 8.1 Jun 2, 2026
zuiderkwast added a commit that referenced this pull request Jun 2, 2026
@zuiderkwast
Attempt to deflake 'diskless no replicas drop during rdb pipe' (#3461)
96722fc 
Increase time to wait for bgsave to start. This wait has been seen
failing in these test cases.

The test case loops with 'no', 'slow', 'fast', 'all' and 'timeout'
replicas, in tests/integration/replication.tcl

Example:

*** [err]: diskless fast replicas drop during rdb pipe in
tests/integration/replication.tcl
    rdb child didn't terminate

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
valkeyrie-ops Bot pushed a commit that referenced this pull request Jun 7, 2026
@zuiderkwast
Attempt to deflake 'diskless no replicas drop during rdb pipe' (#3461)
30f2318 
Increase time to wait for bgsave to start. This wait has been seen
failing in these test cases.

The test case loops with 'no', 'slow', 'fast', 'all' and 'timeout'
replicas, in tests/integration/replication.tcl

Example:

*** [err]: diskless fast replicas drop during rdb pipe in
tests/integration/replication.tcl
    rdb child didn't terminate

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@valkeyrie-ops valkeyrie-ops Bot mentioned this pull request Jun 7, 2026
Open
valkeyrie-ops Bot pushed a commit that referenced this pull request Jun 10, 2026
@zuiderkwast
Attempt to deflake 'diskless no replicas drop during rdb pipe' (#3461)
2ae8f27 
Increase time to wait for bgsave to start. This wait has been seen
failing in these test cases.

The test case loops with 'no', 'slow', 'fast', 'all' and 'timeout'
replicas, in tests/integration/replication.tcl

Example:

*** [err]: diskless fast replicas drop during rdb pipe in
tests/integration/replication.tcl
    rdb child didn't terminate

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@valkeyrie-ops valkeyrie-ops Bot moved this from To be backported to Done in Valkey 7.2 Jun 16, 2026
@valkeyrie-ops valkeyrie-ops Bot moved this from To be backported to Done in Valkey 8.0 Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enjoy-binbin enjoy-binbin enjoy-binbin approved these changes
@hpatro hpatro Awaiting requested review from hpatro

Assignees

@zuiderkwast zuiderkwast

Labels

run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP)

Projects

Valkey 7.2
Status: Done
Valkey 8.0
Status: Done
Valkey 8.1
Status: 8.1.8
Valkey 9.0
Status: To be backported
Valkey 9.1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zuiderkwast @asagege @enjoy-binbin @sarthakaggarwal97