Skip to content

remove duplicated lline#3379

Merged
ranshid merged 1 commit into
valkey-io:unstablefrom
ranshid:dedup-lines
Mar 18, 2026
Merged

remove duplicated lline#3379
ranshid merged 1 commit into
valkey-io:unstablefrom
ranshid:dedup-lines

Conversation

@ranshid

@ranshid ranshid commented Mar 18, 2026

Copy link
Copy Markdown
Member

Probably added by mistake during some merge of #1566

Probably added by mistake during some merge of valkey-io#1566

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
@ranshid ranshid requested a review from enjoy-binbin March 18, 2026 15:17
@ranshid ranshid added the de-crapify Correct crap decisions made in the past label Mar 18, 2026
@ranshid ranshid marked this pull request as ready for review March 18, 2026 15:17
@codecov

codecov Bot commented Mar 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.49%. Comparing base (ac5e44c) to head (7f4b67e).
⚠️ Report is 3 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #3379      +/-   ##
============================================
- Coverage     74.53%   74.49%   -0.04%     
============================================
  Files           130      130              
  Lines         72731    72730       -1     
============================================
- Hits          54208    54181      -27     
- Misses        18523    18549      +26     
Files with missing lines Coverage Δ
src/server.c 89.57% <ø> (+0.02%) ⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ranshid ranshid merged commit afe6ee1 into valkey-io:unstable Mar 18, 2026
92 of 93 checks passed
JimB123 pushed a commit that referenced this pull request Mar 19, 2026
Probably added by mistake during some merge of #1566

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
roshkhatri pushed a commit to roshkhatri/valkey that referenced this pull request Mar 20, 2026
Probably added by mistake during some merge of valkey-io#1566

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/valkey that referenced this pull request Apr 16, 2026
Probably added by mistake during some merge of valkey-io#1566

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
madolson pushed a commit that referenced this pull request Apr 27, 2026
Probably added by mistake during some merge of #1566

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

de-crapify Correct crap decisions made in the past

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants