Add AGENTS.md file for agentic coding assistant steering#3371
Conversation
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
murphyjacob4
left a comment
There was a problem hiding this comment.
Seems like a good start
madolson
left a comment
There was a problem hiding this comment.
How does this overlap with the current copilot.instructions file we have? I think the best practice is to just have one, instead of having copilot read from both.
That seems like more of a set of instructions to review a change and not for development. https://agents.md/ is now pretty much the established standard. |
| ## Build and test | ||
| - Default build: `make` | ||
| - Clean rebuild when build settings or bundled deps change: `make distclean && make` | ||
| - Main test suite: `make test` |
There was a problem hiding this comment.
I tried an agent with this, and it got confused running the unit tests from here. We should probably split off integration and unit tests more clearly. (NOTE: it did figure it out, I was just reading it's thinking)
So should we remove it? |
I've not used Copilot yet. You generally assign the copilot reviewer to the Valkey PRs. Have you found it useful? |
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
soloestoy
left a comment
There was a problem hiding this comment.
LGTM, this is for valkey developers and we also need user-agents-development.md for users.
Right. Do regular users checkout the repo and interact with agents around it? |
Review is only one use case of copilot, it also has an agent mode, I've assigned tasks to it sometimes and it will go do work. I've found the reviews to be the least useful component of it. |
No, I think that is closer to this: https://github.com/redis/agent-skills |
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
No description provided.