Deflake io-threads test by generating enough work#3354
Merged
zuiderkwast merged 2 commits intoMar 11, 2026
Merged
Conversation
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3354 +/- ##
============================================
+ Coverage 75.03% 75.05% +0.01%
============================================
Files 129 129
Lines 71724 71724
============================================
+ Hits 53821 53831 +10
+ Misses 17903 17893 -10 🚀 New features to boost your workflow:
|
JimB123
pushed a commit
that referenced
this pull request
Mar 19, 2026
Fixes the failing run:
```
[err]: Force the use of IO threads and assert active IO thread usage in tests/unit/io-threads.tcl
Expected '0.000000' to be more than '0' (context: type source line 49 file /Users/runner/work/valkey/valkey/tests/unit/io-threads.tcl cmd {assert_morethan $used_active_time 0} proc ::test)
```
The change deflakes the test by generating enough I/O-thread work.
The test previously created 16 deferred clients but only sent 15 total
`INCR` commands. On fast runners, that burst could be short enough that
`used_active_time_io_thread_*` was still reported as `0.000000`, causing
the test to fail even though I/O threads had run.
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing run: https://github.com/valkey-io/valkey/actions/runs/22810251608/job/66165776196#step:7:8704
The change deflakes the test by generating enough I/O-thread work.
The test previously created 16 deferred clients but only sent 15 total
INCRcommands. On fast runners, that burst could be short enough thatused_active_time_io_thread_*was still reported as0.000000, causing the test to fail even though I/O threads had run.Passing Run 200 times: https://github.com/sarthakaggarwal97/valkey/actions/runs/22869618064