Fix timing issue in RDB abort test#3343
Merged
Merged
Conversation
In flushall we will call killRDBChild to kill the RDB child, but we need to wait for checkChildrenDone and waitpid to kick in, so that we can call resetChildState to reset the state. The previous wait_for_condition 10 100 (1s) might not be enough, changed it to wait_for_condition 50 100 (5s). ``` [err]: Test FLUSHALL aborts bgsave in tests/integration/rdb.tcl bgsave not aborted ``` Signed-off-by: Binbin <binloveplay1314@qq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3343 +/- ##
============================================
- Coverage 75.02% 74.86% -0.16%
============================================
Files 129 129
Lines 71632 71632
============================================
- Hits 53739 53626 -113
- Misses 17893 18006 +113 🚀 New features to boost your workflow:
|
zuiderkwast
approved these changes
Mar 10, 2026
JimB123
pushed a commit
that referenced
this pull request
Mar 19, 2026
In flushall we will call killRDBChild to kill the RDB child, but we need to wait for checkChildrenDone and waitpid to kick in, so that we can call resetChildState to reset the state. The previous wait_for_condition 10 100 (1s) might not be enough, changed it to wait_for_condition 50 100 (5s). ``` [err]: Test FLUSHALL aborts bgsave in tests/integration/rdb.tcl bgsave not aborted ``` Signed-off-by: Binbin <binloveplay1314@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In flushall we will call killRDBChild to kill the RDB child, but
we need to wait for checkChildrenDone and waitpid to kick in, so
that we can call resetChildState to reset the state. The previous
wait_for_condition 10 100 (1s) might not be enough, changed it to
wait_for_condition 50 100 (5s).