[flaky-tests] atomically snapshot dual-channel memory stats#3336
Merged
hpatro merged 2 commits intoMar 9, 2026
Merged
Conversation
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
766ea11 to
31789c1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3336 +/- ##
============================================
- Coverage 75.05% 74.97% -0.08%
============================================
Files 129 129
Lines 71553 71632 +79
============================================
+ Hits 53705 53709 +4
- Misses 17848 17923 +75 🚀 New features to boost your workflow:
|
Nikhil-Manglore
approved these changes
Mar 9, 2026
Nikhil-Manglore
left a comment
Member
There was a problem hiding this comment.
Nice fix, I have noticed this failing for a while.
hpatro
approved these changes
Mar 9, 2026
JimB123
added a commit
to JimB123/valkey
that referenced
this pull request
Mar 10, 2026
…alkey-io#3336)" This reverts commit 5deebd0.
JimB123
pushed a commit
that referenced
this pull request
Mar 19, 2026
This fixes a flaky dual-channel replication integration test: https://github.com/valkey-io/valkey/actions/runs/22810251608/job/66165776198#step:8:7701 `INFO memory` field `used_memory_overhead` and `MEMORY STATS` field `overhead.total` can change during dual-channel sync if replica's pending replication buffer is still changing. This is probably more visible in slower environments. The test now collects `INFO` and `MEMORY STATS` in a single `MULTI/EXEC` on both the primary and replica, so the compared values come from the same snapshot. Passing here: https://github.com/sarthakaggarwal97/valkey/actions/runs/22864585326/job/66327772967 Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a flaky dual-channel replication integration test: https://github.com/valkey-io/valkey/actions/runs/22810251608/job/66165776198#step:8:7701
INFO memoryfieldused_memory_overheadandMEMORY STATSfieldoverhead.totalcan change during dual-channel sync if replica's pending replication buffer is still changing. This is probably more visible in slower environments.The test now collects
INFOandMEMORY STATSin a singleMULTI/EXECon both the primary and replica, so the compared values come from the same snapshot.Passing here: https://github.com/sarthakaggarwal97/valkey/actions/runs/22864585326/job/66327772967