Changed LUA module dependency#3325
Conversation
Before this change, if you built `valkey-server` (e.g. `make valkey-server`) the LUA module was not built. With this change, the LUA module is now a direct a dependency of `valkey-server` - (unless `BUILD_LUA=no` is passed) Added some colors to the Lua module & Lua lib `Makefile`s to they blend nicely in the build output. Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3325 +/- ##
============================================
- Coverage 74.92% 74.92% -0.01%
============================================
Files 129 129
Lines 71549 71549
============================================
- Hits 53608 53607 -1
- Misses 17941 17942 +1 🚀 New features to boost your workflow:
|
sarthakaggarwal97
left a comment
There was a problem hiding this comment.
Looks good, thanks!
ranshid
left a comment
There was a problem hiding this comment.
Overall LGTM.
Not sure if this is that important to change our vended LUA Makefile (even if it yield a nicer output)
|
@ranshid I am not sure what to do with your comment: do you want me to remove the changes from the LUA Makefiles or not? (personally, I think we should keep it, but I am getting the sense that you are against it). |
Currently do nothing. I just wonder how much this will potentially slow us down when we will want to upgrade lua in the future. @rjd15372 WDYT? |
It should be OK. A new Lua runtime will come with its own Makefile. |
Before this change, if you built `valkey-server` (e.g. `make valkey-server`) the LUA module was not built. With this change, the LUA module is now a direct a dependency of `valkey-server` - (unless `BUILD_LUA=no` is passed) Added some colors to the Lua module & Lua lib `Makefile`s to they blend nicely in the build output. Signed-off-by: Eran Ifrah <eifrah@amazon.com> Signed-off-by: Daniel Lemire <daniel@lemire.me>
This reverts commit 9f01067.
Before this change, if you built `valkey-server` (e.g. `make valkey-server`) the LUA module was not built. With this change, the LUA module is now a direct a dependency of `valkey-server` - (unless `BUILD_LUA=no` is passed) Added some colors to the Lua module & Lua lib `Makefile`s to they blend nicely in the build output. Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Before this change, if you built
valkey-server(e.g.make valkey-server) the LUA module was not built. With this change, the LUA module is now a direct a dependency ofvalkey-serverBUILD_LUA=nois passed)Added some colors to the Lua module & Lua lib
Makefiles to they blend nicely in the build output.