fix Codecov v5 input from file to files#3308
Merged
Merged
Conversation
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3308 +/- ##
=============================================
+ Coverage 0 74.92% +74.92%
=============================================
Files 0 129 +129
Lines 0 71547 +71547
=============================================
+ Hits 0 53607 +53607
- Misses 0 17940 +17940 🚀 New features to boost your workflow:
|
Nikhil-Manglore
approved these changes
Mar 4, 2026
zuiderkwast
approved these changes
Mar 5, 2026
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
Great finding, thanks!
Not very backward compatible of that workflow to break this. Seems they could have kept support for file as an alias.
eifrah-aws
pushed a commit
to eifrah-aws/valkey
that referenced
this pull request
Mar 5, 2026
This PR fixes a Codecov workflow misconfiguration introduced when upgrading codecov/codecov-action from v4 to v5 (in valkey-io#3185). In v5, the action expects files (plural), but the workflow still used file. The coverage shown is 0 right now: https://app.codecov.io/gh/valkey-io/valkey Documentation from - https://github.com/codecov/codecov-action/tree/v5?tab=readme-ov-file#arguments ``` The following arguments have been changed file (this has been deprecated in favor of files) plugin (this has been deprecated in favor of plugins) ``` Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
This PR fixes a Codecov workflow misconfiguration introduced when upgrading codecov/codecov-action from v4 to v5 (in valkey-io#3185). In v5, the action expects files (plural), but the workflow still used file. The coverage shown is 0 right now: https://app.codecov.io/gh/valkey-io/valkey Documentation from - https://github.com/codecov/codecov-action/tree/v5?tab=readme-ov-file#arguments ``` The following arguments have been changed file (this has been deprecated in favor of files) plugin (this has been deprecated in favor of plugins) ``` Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
akashkgit
pushed a commit
to akashkgit/valkey
that referenced
this pull request
Mar 6, 2026
This PR fixes a Codecov workflow misconfiguration introduced when upgrading codecov/codecov-action from v4 to v5 (in valkey-io#3185). In v5, the action expects files (plural), but the workflow still used file. The coverage shown is 0 right now: https://app.codecov.io/gh/valkey-io/valkey Documentation from - https://github.com/codecov/codecov-action/tree/v5?tab=readme-ov-file#arguments ``` The following arguments have been changed file (this has been deprecated in favor of files) plugin (this has been deprecated in favor of plugins) ``` Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a Codecov workflow misconfiguration introduced when upgrading codecov/codecov-action from v4 to v5 (in #3185).
In v5, the action expects files (plural), but the workflow still used file.
The coverage shown is 0 right now: https://app.codecov.io/gh/valkey-io/valkey
Documentation from - https://github.com/codecov/codecov-action/tree/v5?tab=readme-ov-file#arguments