Let script continue if busy-reply-threshold is zero by alon-arenberg · Pull Request #3307 · valkey-io/valkey

alon-arenberg · 2026-03-04T15:07:27Z

Before we added LUA as a module we had a logic to NOT register the
luaHook when the value of busy-reply-threshold config is set to 0.

Now we ALWAYS register the hook and in order to keep aligned with
old behavior we will let the execution of the script continue from
the interrupt hook when busy-reply-threshold config is set == 0.

And in value.conf, we are saying the config can be negative, but in
fact the config is minimum at 0, fix the valkey.conf as well.

# The default is 5 seconds. It is possible to set it to 0 or a negative value
# to disable this mechanism (uninterrupted execution)

It was introduced in #2858.

rjd15372

LGTM

Signed-off-by: Alon Arenberg <alonare@amazon.com>

roshkhatri

LGTM!

here is where we set hook before

    if (server.busy_reply_threshold > 0 && !debug_enabled) {
        lua_sethook(lua, luaMaskCountHook, LUA_MASKCOUNT, 100000);
        delhook = 1;
    }

sarthakaggarwal97

LGTM!

enjoy-binbin

So it was introduced in #2858.

Signed-off-by: Binbin <binloveplay1314@qq.com>

enjoy-binbin · 2026-03-05T02:46:12Z

FYI, i update the condition to server.busy_reply_threshold > 0 and update the top comment, that is the old behavior

enjoy-binbin

Wait. Please double check the old luaCallFunction and scriptInterrupt. I lost some details here.

alon-arenberg · 2026-03-05T07:52:00Z

I think the proposed code change is not correct. Pushing the original commit

…s set to 0 Signed-off-by: Alon Arenberg <alonare@amazon.com>

enjoy-binbin · 2026-03-05T11:39:46Z

i was thinking something like this, can we add this fast path before the elapsedMs?

if (server.busy_reply_threshold == 0) {
        return SCRIPT_CONTINUE;
    }

enjoy-binbin · 2026-03-05T11:42:56Z

Ran mentions the config is minimum at 0, and the valkey.conf is saying it can be negative, we need to fix the conf as well.

# The default is 5 seconds. It is possible to set it to 0 or a negative value
# to disable this mechanism (uninterrupted execution). Note that in the past
# this config had a different name, which is now an alias, so both of these do
# the same:
# lua-time-limit 5000
# busy-reply-threshold 5000

…alkey.conf Signed-off-by: Alon Arenberg <alonare@amazon.com>

enjoy-binbin

LGTM, thank!

Signed-off-by: Alon Arenberg <alonare@amazon.com>

codecov · 2026-03-05T15:40:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.89%. Comparing base (896e9c8) to head (045620f).
⚠️ Report is 5 commits behind head on unstable.

Additional details and impacted files

@@              Coverage Diff              @@
##           unstable    #3307       +/-   ##
=============================================
+ Coverage          0   74.89%   +74.89%     
=============================================
  Files             0      129      +129     
  Lines             0    71549    +71549     
=============================================
+ Hits              0    53588    +53588     
- Misses            0    17961    +17961

Files with missing lines	Coverage Δ
src/script.c	`89.24% <100.00%> (ø)`

... and 128 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Before we added LUA as a module we had a logic to NOT register the luaHook when the value of `busy-reply-threshold` config is set to 0. Now we ALWAYS register the hook and in order to keep aligned with old behavior we will let the execution of the script continue from the interrupt hook when `busy-reply-threshold` config is set == 0. And in value.conf, we are saying the config can be negative, but in fact the config is minimum at 0, fix the valkey.conf as well. ``` # The default is 5 seconds. It is possible to set it to 0 or a negative value # to disable this mechanism (uninterrupted execution) ``` It was introduced in valkey-io#2858. Signed-off-by: Alon Arenberg <alonare@amazon.com> Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com>

Before we added LUA as a module we had a logic to NOT register the luaHook when the value of `busy-reply-threshold` config is set to 0. Now we ALWAYS register the hook and in order to keep aligned with old behavior we will let the execution of the script continue from the interrupt hook when `busy-reply-threshold` config is set == 0. And in value.conf, we are saying the config can be negative, but in fact the config is minimum at 0, fix the valkey.conf as well. ``` # The default is 5 seconds. It is possible to set it to 0 or a negative value # to disable this mechanism (uninterrupted execution) ``` It was introduced in valkey-io#2858. Signed-off-by: Alon Arenberg <alonare@amazon.com> Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>

Before we added LUA as a module we had a logic to NOT register the luaHook when the value of `busy-reply-threshold` config is set to 0. Now we ALWAYS register the hook and in order to keep aligned with old behavior we will let the execution of the script continue from the interrupt hook when `busy-reply-threshold` config is set == 0. And in value.conf, we are saying the config can be negative, but in fact the config is minimum at 0, fix the valkey.conf as well. ``` # The default is 5 seconds. It is possible to set it to 0 or a negative value # to disable this mechanism (uninterrupted execution) ``` It was introduced in valkey-io#2858. Signed-off-by: Alon Arenberg <alonare@amazon.com> Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com>

github-actions Bot assigned alon-arenberg Mar 4, 2026

rjd15372 approved these changes Mar 4, 2026

View reviewed changes

ranshid requested a review from enjoy-binbin March 4, 2026 15:16

let script continue if busy-reply-threshold is zero

5930096

Signed-off-by: Alon Arenberg <alonare@amazon.com>

alon-arenberg force-pushed the busy-reply-threshold-zero branch from cfe7e9f to 5930096 Compare March 4, 2026 15:18

roshkhatri approved these changes Mar 4, 2026

View reviewed changes

sarthakaggarwal97 approved these changes Mar 4, 2026

View reviewed changes

enjoy-binbin approved these changes Mar 5, 2026

View reviewed changes

enjoy-binbin added this to Valkey 9.1 Mar 5, 2026

enjoy-binbin changed the title ~~let script continue if busy-reply-threshold is zero~~ Let script continue if busy-reply-threshold is zero Mar 5, 2026

enjoy-binbin reviewed Mar 5, 2026

View reviewed changes

Comment thread src/script.c Outdated

Apply suggestion from @enjoy-binbin

d6fee83

Signed-off-by: Binbin <binloveplay1314@qq.com>

enjoy-binbin requested changes Mar 5, 2026

View reviewed changes

fix condition to let script continue if busy-reply-threshold config i…

be56e28

…s set to 0 Signed-off-by: Alon Arenberg <alonare@amazon.com>

adding a fast path before the elapsedMs and fixing documentation in v…

d6f365f

…alkey.conf Signed-off-by: Alon Arenberg <alonare@amazon.com>

enjoy-binbin approved these changes Mar 5, 2026

View reviewed changes

nit: remove white space

045620f

Signed-off-by: Alon Arenberg <alonare@amazon.com>

enjoy-binbin merged commit cb9e7c9 into valkey-io:unstable Mar 5, 2026
57 of 58 checks passed

github-project-automation Bot moved this to Done in Valkey 9.1 Mar 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Let script continue if busy-reply-threshold is zero#3307

Let script continue if busy-reply-threshold is zero#3307
enjoy-binbin merged 5 commits into
valkey-io:unstablefrom
alon-arenberg:busy-reply-threshold-zero

alon-arenberg commented Mar 4, 2026 •

edited by enjoy-binbin

Loading

Uh oh!

rjd15372 left a comment

Uh oh!

roshkhatri left a comment •

edited

Loading

Uh oh!

sarthakaggarwal97 left a comment

Uh oh!

enjoy-binbin left a comment

Uh oh!

Uh oh!

enjoy-binbin commented Mar 5, 2026

Uh oh!

enjoy-binbin left a comment

Uh oh!

alon-arenberg commented Mar 5, 2026

Uh oh!

enjoy-binbin commented Mar 5, 2026 •

edited

Loading

Uh oh!

enjoy-binbin commented Mar 5, 2026

Uh oh!

enjoy-binbin left a comment

Uh oh!

codecov Bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

alon-arenberg commented Mar 4, 2026 • edited by enjoy-binbin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rjd15372 left a comment

Choose a reason for hiding this comment

Uh oh!

roshkhatri left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sarthakaggarwal97 left a comment

Choose a reason for hiding this comment

Uh oh!

enjoy-binbin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

enjoy-binbin commented Mar 5, 2026

Uh oh!

enjoy-binbin left a comment

Choose a reason for hiding this comment

Uh oh!

alon-arenberg commented Mar 5, 2026

Uh oh!

enjoy-binbin commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

enjoy-binbin commented Mar 5, 2026

Uh oh!

enjoy-binbin left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alon-arenberg commented Mar 4, 2026 •

edited by enjoy-binbin

Loading

roshkhatri left a comment •

edited

Loading

enjoy-binbin commented Mar 5, 2026 •

edited

Loading

codecov Bot commented Mar 5, 2026 •

edited

Loading