In 53d1acd we decided to always replica in absolute timestamps. I don't remember the context, but guess matters when the replication is lagging and in AOF files.

In 53d1acd we decided to always replica in absolute timestamps

This PR did not change it, we still rewrite it as absolute timestamps. (And btw, we have a lot of abs-ttl test around it in expire.tcl, so we did not change anything)

The different is:

Before this PR, a SET key value EX/PX/EXAT ttl will be rewrite to SET key value PXAT abs_ttl, we call rewriteClientCommandVector and rewrite the whole argv vector.

And in this PR, a SET key value EX/PX/EXAT ttl is still will be rewrite to SET key value PXAT abs_ttl, but we only call rewriteClientCommandArgument twice to rewrite the two arg. Like rewrite EX to PXAT, and rewrite ttl to abs_ttl

If a command is SET key value EX/PX/EXAT ttl

rewriteClientCommandVector rewrite the whole argv:

• set to set
• key to key
• value to value
• EX/PX/EXAT to PXAT
• ttl to abs-ttl

And in this PR, we only rewrite those args that need rewriting:

- EX/PX/EXAT to PXAT
- ttl to abs-ttl

would it make sense to add a test that verifies this argc == 5 path?

we already had a lot of it

    # Start a new server with empty data and AOF file.
    start_server {overrides {appendonly {yes} appendfsync always} tags {external:skip}} {
        test {All time-to-live(TTL) in commands are propagated as absolute timestamp in milliseconds in AOF} {
            # This test makes sure that expire times are propagated as absolute
            # times to the AOF file and not as relative time, so that when the AOF
            # is reloaded the TTLs are not being shifted forward to the future.
            # We want the time to logically pass when the server is restarted!

            set aof [get_last_incr_aof_path r]

            # Apply each TTL-related command to a unique key
            # SET commands
            r set foo1 bar ex 100
            r set foo2 bar px 100000
            r set foo3 bar exat [expr [clock seconds]+100]
            r set foo4 bar PXAT [expr [clock milliseconds]+100000]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (834dc83) to head (022aff9).
⚠️ Report is 34 commits behind head on unstable.

@@       Coverage Diff        @@
##   unstable   #3279   +/-   ##
================================
================================