Suppress valgrind for BIO jobs#3277
Merged
JimB123 merged 2 commits intoFeb 28, 2026
Merged
Conversation
Signed-off-by: Alina Liu <liusalisa6363@gmail.com>
JimB123
requested changes
Feb 28, 2026
Signed-off-by: Alina Liu <liusalisa6363@gmail.com>
JimB123
approved these changes
Feb 28, 2026
JimB123
left a comment
Member
There was a problem hiding this comment.
Looks ok. We'll run some tests before submission.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3277 +/- ##
================================
================================
🚀 New features to boost your workflow:
|
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
Suppress valgrind for BIO jobs valgrind errors: https://github.com/valkey-io/valkey/actions/runs/21969557125/job/63467641572#step:6:8648 ## Changes - Add `allocBioJob()` with `__attribute__((noinline))` as a centralized allocation function for all BIO jobs. The `noinline` attribute ensures it appears as a distinct frame in valgrind stack traces. - Replace all direct `zmalloc` calls in `bioCreate*Job` functions with`allocBioJob()`. - Add a valgrind suppression in `src/valgrind.sup` matching definite leaks with `allocBioJob` in the call stack. - Remove `current_job` introduced in valkey-io#3256 --------- Signed-off-by: Alina Liu <liusalisa6363@gmail.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppress valgrind for BIO jobs valgrind errors: https://github.com/valkey-io/valkey/actions/runs/21969557125/job/63467641572#step:6:8648
Changes
allocBioJob()with__attribute__((noinline))as a centralized allocation function for all BIO jobs. Thenoinlineattribute ensures it appears as a distinct frame in valgrind stack traces.zmalloccalls inbioCreate*Jobfunctions withallocBioJob().src/valgrind.supmatching definite leaks withallocBioJobin the call stack.current_jobintroduced in Replace mutexQueuePeek with current_job field for BIO memcheck fix #3256