Fix type of now parameter in rdbLoadObject() to use mstime_t instead of time_t#3255
Merged
ranshid merged 3 commits intoFeb 25, 2026
Conversation
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
…stamps Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
enjoy-binbin
approved these changes
Feb 25, 2026
ranshid
approved these changes
Feb 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3255 +/- ##
================================
================================
🚀 New features to boost your workflow:
|
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
…of time_t (valkey-io#3255) Fix valkey-io#3254 ### Problem The now parameter in rdbLoadObject() was declared as time_t, which truncates millisecond timestamps on 32-bit systems, causing hash field expiry checks to fail during RDB load. Reproduced: https://github.com/hanxizh9910/valkey/actions/runs/22382739246/job/64786946078 ### Fix Changed time_t now → mstime_t now in the declaration and definition of rdbLoadObject(). ### Test run https://github.com/hanxizh9910/valkey/actions/runs/22383363092 --------- Signed-off-by: Hanxi Zhang <hanxizh@amazon.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3254
Problem
The now parameter in rdbLoadObject() was declared as time_t, which truncates millisecond timestamps on 32-bit systems, causing hash field expiry checks to fail during RDB load.
Reproduced: https://github.com/hanxizh9910/valkey/actions/runs/22382739246/job/64786946078
Fix
Changed time_t now → mstime_t now in the declaration and definition of rdbLoadObject().
Test run
https://github.com/hanxizh9910/valkey/actions/runs/22383363092